-
Notifications
You must be signed in to change notification settings - Fork 17
Description
Issue:
For SPECFEM configuration .yaml files, parameter_parser looks for a "time-interval" node in plot_wavefield (display), but a "time_interval" node in wavefield (dump files).
These should probably be made the same.
Background
(up to date as of 2025-12-01)
It looks like the following are the only places in the code where these two are relevant (from a VS Code search) in devel:
SPECFEMPP/src/parameter_parser/writer/plot_wavefield.cpp
Lines 53 to 60 in b76591c
| const int time_interval = [&]() -> int { | |
| if (Node["time-interval"]) { | |
| return Node["time-interval"].as<int>(); | |
| } else { | |
| throw std::runtime_error( | |
| "Time interval not specified in the display section"); | |
| } | |
| }(); |
SPECFEMPP/src/parameter_parser/writer/wavefield.cpp
Lines 38 to 44 in b76591c
| const int time_interval = [&]() -> int { | |
| if (Node["time_interval"]) { | |
| return Node["time_interval"].as<int>(); | |
| } else { | |
| return 0; | |
| } | |
| }(); |
It also appears that no .yaml files within devel at present use time_interval for wavefields, so the least intrusive fix would be to change "time_interval" to "time-interval".