Specfem-Core-Framework-Logger-Impl #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rohit-Kakodkar <[email protected]>
Co-authored-by: Rohit-Kakodkar <[email protected]>
1178 Part I - Remove write_adjacency_map flag
- [x] Adds a dimension tag to materials - [x] Adds element tags within the mesher - [x] Adds constructor to element types - [x] Adds constructor to assembly properties
- [x] Adds new constructor for receivers - [x] MESHFEM3D mesher now writes number of NGLL points - [x] Added element grid to mesh struct - [x] Added test to check element grid
Co-authored-by: Rohit-Kakodkar <[email protected]>
…lease-io preset Co-authored-by: Rohit-Kakodkar <[email protected]>
…able code Co-authored-by: Rohit-Kakodkar <[email protected]>
Co-authored-by: Rohit-Kakodkar <[email protected]>
…Available Co-authored-by: Rohit-Kakodkar <[email protected]>
Co-authored-by: Rohit-Kakodkar <[email protected]>
…ehavior Co-authored-by: Rohit-Kakodkar <[email protected]>
Co-authored-by: Rohit-Kakodkar <[email protected]>
Minor change to nc container constructor
The next step will be removing the specfem::MPI::MPI object and function passes.
Documentation Update - Assembly sources
Upgrades MESHFEM3D mesher input
This PR adds missing changes from [this](SPECFEM/specfem2d@43b5f49#diff-787b37144d69780313d23b0726a283f3a23cb81e4b04686afb4dff1c565997ef) commit from the original fortran code.
Issue 1379 - Deprecate Fortran generate database
Rohit-Kakodkar
requested changes
Nov 24, 2025
Collaborator
Rohit-Kakodkar
left a comment
Rohit-Kakodkar
left a comment
There was a problem hiding this comment.
We need to talk about how to safely abort code in a hybrid Kokkos/MPI code.
icui
approved these changes
Nov 24, 2025
[Fix] Fixes meshfem2D for fluid solid coupling
1178 - Construct assembly::coupled_interfaces from adjacency_graph
gmshlayerbuilder: allow solids to skip AFS mark
…ramework-depr-mpi-cout
Rohit-Kakodkar
approved these changes
Dec 2, 2025
| // Print/log error message if provided | ||
| if (!full_message.empty()) { | ||
| // Check if we're inside a valid program context | ||
| if (specfem::MPI_new::rank != -1 && specfem::MPI_new::size != -1) { |
Collaborator
There was a problem hiding this comment.
Should this be specfem::MPI_new::check_context()
| } | ||
|
|
||
| // Check if we're inside a valid program context by checking MPI_new state | ||
| if (specfem::MPI_new::rank != -1 && specfem::MPI_new::size != -1) { |
…ork-depr-mpi-cout Specfem Core Framework Depr Mpi Cout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the logger struct and moves some things into the discussed namespaces.
Issue Number
Updates #1149
Checklist
Please make sure to check developer documentation on specfem docs.