-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name and ref suppressed in favor of destination on non-motorway #225
Comments
Why not to have new texts including |
Brevity, primarily. For example, turning left, this is already wordy enough:
I don’t think there’s enough ambiguity in this instruction to justify an additional clause:
In this case, |
In OpenStreetMap, the
destination
tag can be used on anyhighway
way, not just ramps, to encode what’s posted on guide signage. While usage on non-ramps such as surface streets is relatively rare in the U.S., it is important in some cases involving collector-distributor ramps. Unfortunately, OSRM Text Instructions gives undue preference to the destination tag on surface streets, ignoring the name and ref that are more likely to be useful to a driver.Example
The interchange between I-275 and SR 32 east of Cincinnati features multiple weaving collector-distributor ramps:
This example involves several branches, highlighted in this map.
I-275 is a freeway. SR 32 is an expressway that has freeway-style exits interspersed with at-grade intersections, so it’s tagged
highway=trunk
and treated as a non-motorway by OSRM.The problematic route starts with this highway exit:
Expected instructions:
Actual instructions: ✅
Then it splits into two ramps, exit 63A on the left and exit 63B on the right:
Despite the exit 63A signage, the ramp to the left goes both westbound toward Newtown and eastbound toward the Eastgate Boulevard exit:
The little green sign on the right side of this photo is for the ramp on the left side of the photo.
Actual instructions:
Actual instructions:
The
destination
on these two segments of SR 32 tag cause OSRM Text Instructions to omit the name and ref from text and voice instructions in favor of the destination, which is the least important information at the at-grade intersection with SR 32.Diagnosis
The root cause is this code that unconditionally prioritizes a step’s
destination
over itsname
andref
(contained in thewayName
variable):osrm-text-instructions/index.js
Lines 178 to 183 in 42e39ed
This code needs to consider the passed-in road classes: for
motorway
, it should choosedestination
; otherwise, it should choosewayName
./cc @lyzidiamond @allierowan
The text was updated successfully, but these errors were encountered: