Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove local workspace Rollup resolution work around #1318

Open
thescientist13 opened this issue Nov 14, 2024 · 0 comments
Open

remove local workspace Rollup resolution work around #1318

thescientist13 opened this issue Nov 14, 2024 · 0 comments
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

Enhancement

Summary

When the website repo was part of the monorepo workspace, there was a need to have a work around to resolve references to @greenwood/* to the local workspace file, since it wouldn't actually be in node_modules
https://github.com/ProjectEvergreen/greenwood/blob/v0.30.1/packages/cli/src/config/rollup.config.js#L138

Details

In theory we should just be able to delete that if block and comment and all tests should continue to pass.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers CLI labels Nov 14, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant