Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery view: first dev implementation #2032

Closed
8 tasks done
camillevilla opened this issue Mar 2, 2019 · 0 comments
Closed
8 tasks done

Gallery view: first dev implementation #2032

camillevilla opened this issue Mar 2, 2019 · 0 comments
Assignees

Comments

@camillevilla
Copy link
Member

camillevilla commented Mar 2, 2019

No item selected, manifest metadata displayed
screen shot 2019-02-15 at 2 41 25 pm
Item selected in gallery, canvas metadata inserted
screen shot 2019-02-15 at 2 41 42 pm

Acceptance Criteria

  • User can select "Gallery" from window topbar
    • Uses CustomGalleryView SVG from Standardized icon set #1947
      <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M19.974,2H2V19.974H19.974V2ZM7.392,18.177H3.8V14.582H7.392Zm0-5.392H3.8V9.19H7.392Zm0-5.392H3.8V3.8H7.392Zm5.392,10.785H9.19V14.582h3.595Zm0-5.392H9.19V9.19h3.595Zm0-5.392H9.19V3.8h3.595Zm5.392,10.785H14.582V14.582h3.595Zm0-5.392H14.582V9.19h3.595Zm0-5.392H14.582V3.8h3.595Z" transform="translate(1 1)"/></svg>
    • Wraps icon in MUI <SvgIcon> for theme-ability. See approach in Standardize icons to Sharp versions #1967 used for other custom SVGs
  • Uses a vanilla HTML implementation (not something canvas-based, like OSD Collection mode per discussion with tech lead and design team) so that content will be keyboard navigable
  • Clicking on a canvas
    • Provides a visual indicator around selected canvas (see mockup)
    • Updates canvasIndex
    • viewer stays in Gallery view (i.e. this is a departure from Mirador 2 gallery behavior)
  • Switching to an alternate view (single, book) opens to the selected canvas

Nice to haves

Out of Scope

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants