Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted favicon domains database #297

Open
mKoonrad opened this issue Jan 5, 2023 · 1 comment
Open

Trusted favicon domains database #297

mKoonrad opened this issue Jan 5, 2023 · 1 comment

Comments

@mKoonrad
Copy link

mKoonrad commented Jan 5, 2023

Hello
I recognized in my way your API for viewing sender images in Proton Mail packages/shared/lib/api/images.ts

I discovered that you only serve some “trusted domains” favicons. Is there any option to make this list public? Or can you provide any option to suggest missing popular and trusted domains? It's very helpful UX feature, but I can't see many domains with this image.

@danielwaltz
Copy link

Also curious about this! I believe it's also related to #408 and may explain why there are a good number of logins in Proton Pass that are missing favicons.

I imagine there are security reasons why there is an allowlist, but it would be nice if that list were relaxed a little bit to support more domains. Or perhaps reverse it to blocklist of known malicious urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants