Fix activation launch and potential threading issues

Author: Thomas Felices

src/Client/Common/ProtonVPN.Client.Common/Observers/ObserverBase.cs

@@ -38,11 +38,11 @@ public ObserverBase(ILogger logger, IIssueReporter issueReporter)
         TriggerAction = new SingleAction(OnSafeTriggerAsync);
     }
 
-    private void OnSafeTriggerAsync()
+    private async Task OnSafeTriggerAsync()
     {
         try
         {
-            OnTriggerAsync();
+            await OnTriggerAsync();
         }
         catch (Exception ex)
         {

src/Client/Logic/Servers/ProtonVPN.Client.Logic.Servers/Observers/DeviceLocationObserver.cs

@@ -151,7 +151,7 @@ private async Task FetchDeviceLocationAsync(int delayInMs)
 
             await Task.Delay(delayInMs);
 
-            await OnTriggerAsync();
+            TriggerAction.Run();
         }
         finally
         {

src/Client/ProtonVPN.Client/Services/Bootstrapping/Bootstrapper.cs

@@ -179,9 +179,15 @@ await _mainWindowOverlayActivator.ShowLoadingMessageAsync(
 
     private void OnCurrentAppInstanceActivated(object? sender, AppActivationArguments e)
     {
-        if (e.Kind == ExtendedActivationKind.Protocol)
+        switch (e.Kind)
         {
-            HandleProtocolActivationArguments(e.Data as ProtocolActivatedEventArgs);
+            case ExtendedActivationKind.Protocol:
+                HandleProtocolActivationArguments(e.Data as ProtocolActivatedEventArgs);
+                break;
+            default:
+                _logger.Debug<AppLog>($"Handle {e.Kind} activation - Activate window");
+                _mainWindowActivator.Activate();
+                break;
         }
     }
 

src/Client/ProtonVPN.Client/Services/Bootstrapping/Helpers/AppInstanceHelper.cs

@@ -63,7 +63,7 @@ private static void RedirectActivationTo(AppInstance keyInstance, AppActivationA
            [_redirectEventHandle], out uint handleIndex);
 
         // Bring the window to the foreground
-        //BringToForeground();
+        BringToForeground();
     }
 
     private static void BringToForeground()

src/Common/ProtonVPN.Common.Core/Threading/TaskCompletionSourceExtensions.cs

@@ -23,26 +23,27 @@ public static class TaskCompletionSourceExtensions
 {
     public static Task Wrap(this TaskCompletionSource<object?> source, Func<Task> action)
     {
-        return source.Wrap(async () =>
+        return source.WrapAsync(async () =>
         {
             await action();
             return null;
         });
     }
 
-    public static async Task Wrap<T>(this TaskCompletionSource<T?> source, Func<Task<T?>> function)
+    public static async Task WrapAsync<T>(this TaskCompletionSource<T?> source, Func<Task<T?>> function)
     {
         try
         {
-            source.SetResult(await function());
+            T? result = await function();
+            source.TrySetResult(result);
         }
         catch (OperationCanceledException)
         {
-            source.SetCanceled();
+            source.TrySetCanceled();
         }
         catch (Exception e)
         {
-            source.SetException(e);
+            source.TrySetException(e);
         }
     }
 }