Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused "Remove Partymember" event in code #73

Open
Pyrdacor opened this issue Oct 27, 2022 · 4 comments
Open

Unused "Remove Partymember" event in code #73

Pyrdacor opened this issue Oct 27, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@Pyrdacor
Copy link
Owner

Pyrdacor commented Oct 27, 2022

As I explore the code more and more I will write down some findings here:

Beside the 23 used events, documented here, there is an unused 24th. It can theoretically be used by maps even in the original and there is actually code for the event. After some research it has the following form:

Offset Size Description
00 1 0x18 (event type)
01 1 Character index
02 1 Chest index for equipment
03 1 Chest index for inventory items
04 8 Unused

This event checks party members 2 to 6 (so it skips the hero for soon obvious reasons) to match the given character index. The character index is the sub-file index inside Party_char.amb. So 1 would be Netsrak, 5 would be Monika and so on.

Then it tries to move all equipped items to a chest and all inventory items to another chest (both chests could be the same of course).

At the end the character is removed from the party.

There is a bug in the code where the amount of slots is stored in D1 instead of D7 (which is the loop counter). Therefore the event would not work.

@Pyrdacor Pyrdacor added the documentation Improvements or additions to documentation label Oct 27, 2022
@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Oct 27, 2022

I added it to the docs with hints that it is bugged in the original.

@Pyrdacor Pyrdacor changed the title Code Findings Unused "Remove Partymember" event in code Oct 27, 2022
@a1exh
Copy link

a1exh commented Oct 27, 2022

It is possible to let a character leave the party no? That uses a different method? What might have been the original intent of this event?

@Pyrdacor
Copy link
Owner Author

That event exactly lets a character leave the party but stores its items in chests beforehand. I would think about something like in Albion when Rainer leaves the party for some reason.

@Pyrdacor
Copy link
Owner Author

Maybe they planned that Valdyn could actually leave through the teleporter forever and he drops his items in a nearby wall storage in the Antique Area beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants