player.play() doesn't correctly handle sound files with non-default format #358
Comments
|
Hello! Thanks for the issue. If this is a general help question, for a faster response consider joining the official Discord Server Else if you have an issue with the library please wait for someone to help you here. |
|
I don't have any 5.1 or 7.1 files, but I would guess they will also be handled incorrectly, maybe the pitch will shift down? |
iarspider
changed the title
|
So, a small update: before |
|
can confirm - my mono
until I changed the lines as suggested above: self.proc = subprocess.Popen(
[
ffmpeg_bin,
"-i",
source,
"-loglevel",
"panic",
"-vn",
"-f",
"s16le",
"-ab",
"128",
"-ar",
"44100",
"-ac",
"2",
"pipe:1",
], |
|
This is where the sample rate is hard coded. It just appears like this just isnt finished, and local files havnt been fully covered yet. Idk if theres a better way, maybe try to read in sample rate from meta data on audio, but I made a PR to at least allow you to set the values of those things that way we dont have to change the library code anymore lol |
|
The actual rate right now for the audio files must be converted to 48000 and not 44100. I don't think this is mentioned in the docs anywhere and is not trivial find this solution. Is there a problem to merge the PR by @sockheadrps? |
I forgot it existed :) |
|
I think this issue can be closed since #454 addressed the problem in this issue by detecting sample rate and channels from the audio meta data, and exposing both properties with setters just in case the meta data isn’t accurate. |
|
Thanks for looking into it. With this update however, I'm getting weird results - if I play two sounds in a row, the second one isn't played, and holds the file open for eternity. I will try to post a reproducer later. |
|
And here is the reproducer: import asyncio
import os
import time
import eyed3
from pathlib import Path
from twitchio.ext import commands, sounds
class Bot(commands.Bot):
def play_sound(self, sound: str):
soundfile = str(Path(__file__).parent / sound)
sound = sounds.Sound(soundfile)
print("play sound", soundfile)
self.player.play(sound)
duration = eyed3.load(soundfile).info.time_secs
time.sleep(duration)
print(f"slept for {duration}s")
def __init__(self, initial_channels=None):
super().__init__(
token=os.getenv("TWITCH_CHAT_PASSWORD"),
client_id=os.getenv("TWITCH_CHAT_CLIENT_ID"),
nick="arachnobot",
prefix="!",
initial_channels=["#iarspider"],
)
self.player = sounds.AudioPlayer(callback=self.player_done)
async def event_ready(self):
print(f"Ready | {self.nick}")
self.play_sound("ding-sound-effect_1.mp3")
self.play_sound("ding-sound-effect_1.mp3")
async def player_done(self):
print("Player done")
pass
async def main():
global client, twitch_bot
twitch_bot = Bot()
await twitch_bot.start()
if __name__ == "__main__":
asyncio.run(main())(only extra dependency is This outputs: and plays ding only once. |
|
This worked fine before. The |
|
This one works properly: import asyncio
import os
import time
from pathlib import Path
# from dotenv import load_dotenv
from twitchio.ext import commands, sounds
class Bot(commands.Bot):
async def play_sound(self, sound: str):
soundfile = str(Path(__file__).parent / sound)
sound = sounds.Sound(soundfile)
print("wait for lock")
await self.lock.acquire()
print("play sound", soundfile)
self.player.play(sound)
def __init__(self, initial_channels=None):
super().__init__(
token=os.getenv("TWITCH_CHAT_PASSWORD"),
client_id=os.getenv("TWITCH_CHAT_CLIENT_ID"),
nick="arachnobot",
prefix="!",
initial_channels=["#iarspider"],
)
self.lock = asyncio.Lock()
self.player = sounds.AudioPlayer(callback=self.player_done)
async def event_ready(self):
print(f"Ready | {self.nick}")
await self.play_sound("ding-sound-effect_1.mp3")
await self.play_sound("ding-sound-effect_1.mp3")
async def player_done(self):
print("player done")
self.lock.release()
pass
async def main():
global client, twitch_bot
twitch_bot = Bot()
await twitch_bot.start()
if __name__ == "__main__":
# load_dotenv()
asyncio.run(main()) |
Here is the commit for the work I added, it's pretty minimal. Are you sure this isnt an issue with other parts of your code? I dont think I see necessarily where anything I added could have caused anything like this to happen. If you look at the output of your code You're only getting the callback once, which seems a bit odd, but looking further, at the code you're experiencing a bug in, you're using time.sleep, which is a blocking function call for one, but also in the event_ready() function definition, you arent signaling anything in the callback function you passed into the sounds.AudioPlayer object that the audio has completed before loading and playing new audio, so it looks like what's causing the issue is that youre playing the first audio file, and then immediately loading another sound file into it, causing the references the first file made to AudioPlayer.play() to be overwritten. Thats my guess anyways, I didnt test your code, but Im pretty certain it has nothing to do with the merge of this PR, I think it has to do with how youre handling the AudioPlayer itself. I think you should be checking a flag or something set in the callback function before you load and play any other sounds to avoid this kind of issue. Thats how I handle it anyways. Hope that's helpful, sorry for the late response, I hadn't noticed you had mentioned anything in this issue. Any time you need help with something theres a help thread channel in Twitchio's discord, and any new bugs would be better addressed by opening new issues. No worries, I just feel bad your comment wasnt addressed for more than a month. edit: If you would like to look at solutions you can implement yourself in the interim, this is how I handle it in my TTS cog Its a little messy, sorry. Its personal use project, but is fairly simple. |
|
@sockheadrps Sorry for not replying sooner as well. From a quick look at your code, looks you are handling things in a similar manner (just using global variable instead of lock). I like your implementation of sound queue, btw - nice work! |
I'm trying to use the new Sounds ext, and I have noticed that playing mp3 files with only one channel produces weird result - I'd say the file is played at 2x speed, or the pitch is shifted up. Converting the file to stereo fixes the issue.
MediaInfo output for mono file:
MediaInfo output for stereo file:
The text was updated successfully, but these errors were encountered: