Skip to content

Add nightly CI for documentation builds #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

david-pl
Copy link
Contributor

@david-pl david-pl commented May 5, 2025

Closes #228 and possibly also #219

Needs a release of bloqade-circuit v0.2.0 first as it also updates the examples to work with the new version.

Also, I'm checking the versions / commit hashes for the nightly builds and cancel the jobs if nothing has changed. To do this, I'm using github variables. Not sure if this is the best solution. If it is, then we'd need to create the variables (the body can be empty to start with). There are probably permission issues then as well since I don't think the GH_TOKEN has permissions to set github variables and cancel jobs.

@Roger-luo @weinbe58 do you know a better solution for this?

@weinbe58
Copy link
Member

weinbe58 commented May 5, 2025

I think this looks good. What the difference is between the two versions?

@Roger-luo
Copy link
Member

any idea why CI are all failing here?

@david-pl david-pl force-pushed the david/228-docs-ci branch from ad5e874 to 76fd749 Compare May 12, 2025 09:29
Copy link
Contributor

github-actions bot commented May 12, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://QuEraComputing.github.io/bloqade/pr-preview/pr-231/

Built to branch gh-pages at 2025-05-14 09:29 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@david-pl
Copy link
Contributor Author

david-pl commented May 12, 2025

What the difference is between the two versions?

One builds the documentation with the release versions. This is to catch accidental breaking changes in patch versions (to which bloqade is not pinned) in the bloqade-* dependencies.
The other pulls the latest main branch and builds the documentation using that. This is to make sure we fix the docs before releasing a breaking version.

any idea why CI are all failing here?

I updated the examples to a bloqade-circuit version that wasn't available the first time around, I think.

@Roger-luo
Copy link
Member

One builds the documentation with the release versions. This is to catch accidental breaking changes in patch versions (to which bloqade is not pinned) in the bloqade-* dependencies.
The other pulls the latest main branch and builds the documentation using that. This is to make sure we fix the docs before releasing a breaking version.

I think these would serve good explainations maybe we can have them as a comment inside these two GitHub action files? otherwise LGTM.

@david-pl
Copy link
Contributor Author

Good point, I'll add comments.

There's still the printing issue with the multiple line breaks though. Not sure what causes it, I'll have to look into it.

Of course, we could also skip the execution for now, but that makes the CI here kind of useless.

@Roger-luo
Copy link
Member

We can always get rid of rich in the worst case. Rich is doing too much here perhaps.

@david-pl
Copy link
Contributor Author

I tried again to debug this, but I just can't seem to figure it out. I tried every kwarg to Console without success.

Also, it's not just pprint that's broken, but also kernel.print().

@Roger-luo
Copy link
Member

maybe we can merge the action first? Then we can discuss how to fix it separately.

I feel the bug is probably not in rich but in mkdocs plugin.

@david-pl
Copy link
Contributor Author

maybe we can merge the action first? Then we can discuss how to fix it separately.

But this will deploy the docs with the broken printing. Related question, though: should this action actually deploy the docs? We still have the CI for release deployments.

@Roger-luo
Copy link
Member

ok I'm serious considering to just do the printing myself instead of rich now. See also QuEraComputing/kirin#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup nightly doc build CI
3 participants