Skip to content

validation pass what are they? #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roger-luo opened this issue Feb 27, 2025 · 1 comment
Open

validation pass what are they? #292

Roger-luo opened this issue Feb 27, 2025 · 1 comment
Labels
analysis analysis related issues enhancement New feature or request

Comments

@Roger-luo
Copy link
Member

since we are developing more and more dialects. It is now worth thinking how we should do validations. There are many different things to verify here:

  1. the statement verify method that checks if the statement constructed correctly
  2. the statement typecheck method that checks if the statement typed correctly
  3. a simple IR walk that checks e.g any statement doesn't belong to the current dialect group
  4. an actual analysis pass that asserts sizes, bounds check etc.
@Roger-luo Roger-luo added analysis analysis related issues enhancement New feature or request labels Feb 27, 2025
@kaihsin
Copy link
Contributor

kaihsin commented Feb 27, 2025

I think validation pass is similar to analysis pass but its a bit different.

analysis pass require lattice. and depends on the return value as placeholder for analysis result,
while validation one might want to have validation result for all the statements (not just the one that has result value) and not necessarily need a lattice

for example:
qasm2.cx(a,b) # no result value, but one might want to have validation result for this stmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis analysis related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants