fixed clone part

Author: Costya-Y

cloudshell/cp/proxmox/flows/deploy_flow/base_flow.py

@@ -175,7 +175,6 @@ def _deploy(self, request_actions: DeployVMRequestActions) -> DeployAppResult:
                 deploy_app=deploy_app,
                 instance_name=instance_name,
             )
-            self.proxmox_api.get_node_by_vmid(deployed_vm_id)
             if deploy_app.auto_power_on:
                 self.proxmox_api.start_instance(
                     deployed_vm_id,

cloudshell/cp/proxmox/flows/deploy_flow/commands/clone_vm.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
-from contextlib import suppress
-
+import logging
 import time
 
 from cloudshell.cp.core.cancellation_manager import CancellationContextManager
@@ -11,6 +10,8 @@
 from cloudshell.cp.proxmox.handlers.proxmox_handler import ProxmoxHandler
 from cloudshell.shell.core.driver_utils import GlobalLock
 
+logger = logging.getLogger(__name__)
+
 
 class CloneVMCommand(RollbackCommand, GlobalLock):
     def __init__(
@@ -42,22 +43,26 @@ def _execute(self) -> int:
 
         retry = 0
         while retry <= 5:
-            with suppress(UnsuccessfulOperationException):
+            # with suppress(UnsuccessfulOperationException):
+            try:
                 new_vm_id, up_id = self._execute_deploy(src_node)
                 self._api.wait_for_deploy_to_complete(
                     instance_node=src_node,
                     upid=up_id,
                     instance_name=self._instance_name
                 )
+                self._api.get_node_by_vmid(new_vm_id)
+                return new_vm_id
+            except UnsuccessfulOperationException as e:
+                logger.warning(f"Deploy request for {self._instance_name} failed with:"
+                               f" {e}\n Retrying...", exc_info=True)
                 retry += 1
 
-            return new_vm_id
-
         raise UnsuccessfulOperationException(f"Failed to deploy {self._instance_name}")
 
     @GlobalLock.lock
-    def _execute_deploy(self, node) -> int:
-        return self._api.clone_instance(
+    def _execute_deploy(self, node) -> tuple[str, str]:
+        result = self._api.clone_instance(
             instance_id=self._src_instance_id,
             instance_name=self._instance_name,
             instance_node=node,
@@ -66,6 +71,8 @@ def _execute_deploy(self, node) -> int:
             target_storage=self._target_storage,
             target_node=self._target_node,
         )
+        time.sleep(5)
+        return result
 
     def rollback(self):
         if self._cloned_vm_id:

cloudshell/cp/proxmox/handlers/proxmox_handler.py

@@ -108,7 +108,13 @@ def start_instance(
             skip_check
             or not self.get_instance_status(instance_id, node) == PowerState.RUNNING
         ):
-            self._obj.start_instance(node=node, instance_id=instance_id)
+            upid = self._obj.start_instance(node=node, instance_id=instance_id)
+
+            self._task_waiter(
+                node=node,
+                upid=upid,
+                msg=f"Failed to start instance {instance_id} during {{attempt*timeout}} sec",
+            )
 
     def stop_instance(
         self,

cloudshell/cp/proxmox/handlers/rest_api_handler.py

@@ -478,13 +478,14 @@ def get_instance_ifaces(self, node: str, instance_id: int) -> requests.Response:
             cookies={COOKIES: self.ticket},
         )
 
-    def start_instance(self, node: str, instance_id: int) -> None:
+    @Decorators.get_data()
+    def start_instance(self, node: str, instance_id: int) -> requests.Response:
         """Start Virtual Machine."""
         error_map = {
             400: ParamsException,
             401: AuthAPIException,
         }
-        self._do_post(
+        return self._do_post(
             path=f"nodes/{node}/{self.instance_type.value}/{instance_id}/status/start",
             http_error_map=error_map,
             json={"node": node, "vmid": instance_id},