Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Switch back to actions/setup-python #11

Open
colesbury opened this issue Mar 5, 2025 · 4 comments
Open

Switch back to actions/setup-python #11

colesbury opened this issue Mar 5, 2025 · 4 comments

Comments

@colesbury
Copy link
Collaborator

I think this is finally supported upstream in https://github.com/actions/setup-python, although it's not yet in a release.

We may want to switch users back to actions/setup-python and archive this repository.

@rgommers
Copy link
Member

rgommers commented Mar 6, 2025

Finally, congrats on getting that over the finish line - that took some patient effort!

Seems like a good idea; it's probably already better to pin a commit on main for upstream setup-python rather than wait for a release.

We should update the README before archiving. If we do that, let's include (a) the syntax for the minimum commit to pin, and (b) the expected first release that will include support.

Does that sound good?

@ngoldbaum
Copy link

it's probably already better to pin a commit on main for upstream setup-python rather than wait for a release.

Do you happen to know whether dependabot will update a workflow that is pointing at a non-released commit? If so then I agree with this. If not then we'll need to make sure to update again from e.g. 9e62be8 when setup-python does the next release.

@rgommers
Copy link
Member

rgommers commented Mar 7, 2025

Not 100% sure if Dependabot won't try to downgrade it (don't think so, but worth checking). It should be upgrading on new releases; it's just pinning to a commit after all.

@rgommers
Copy link
Member

A release is out now, so time to archive this fork. I'll update the README and then press the archive button.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants