Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support linux-ppc64le #84

Open
jennydaman opened this issue Dec 20, 2024 · 1 comment
Open

Feature request: support linux-ppc64le #84

jennydaman opened this issue Dec 20, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jennydaman
Copy link

The option --create-executable cannot be used with --platform=linux-ppc64le.

pixi-pack pack --create-executable --platform=linux-ppc64le

I get the following error:

Error: could not archive directory: Unsupported platform: linux-ppc64le

I see that the list of supported platforms are hard-coded:

pixi-pack/src/pack.rs

Lines 369 to 377 in 1ed7234

let (os, arch) = match platform {
Platform::Linux64 => ("unknown-linux-musl", "x86_64"),
Platform::LinuxAarch64 => ("unknown-linux-musl", "aarch64"),
Platform::Osx64 => ("apple-darwin", "x86_64"),
Platform::OsxArm64 => ("apple-darwin", "aarch64"),
Platform::Win64 => ("pc-windows-msvc", "x86_64"),
Platform::WinArm64 => ("pc-windows-msvc", "aarch64"),
_ => return Err(anyhow!("Unsupported platform: {}", platform)),
};

In order to support linux-ppc64le, the code above needs to be modified, and binaries of pixi-pack must be built and published via GitHub releases. Seeing that pixi-pack from conda-forge supports linux-ppc64le, it should be able to build in GitHub Actions for GitHub releases as well.

Could this be implemented? (Would it be helpful for me to draft a PR for this? I can get the code started, but since the issue is related to release engineering, half the work must be done by someone who owns this repo.)

@pavelzw pavelzw added the enhancement New feature or request label Dec 21, 2024
@pavelzw
Copy link
Member

pavelzw commented Dec 21, 2024

The major thing for this to be implemented is cross-building the executable in CI:

If we get this to work (which should be possible, see conda-forge), I'm happy to add the binaries 👍

Feel free to open a PR :)

@pavelzw pavelzw added the good first issue Good for newcomers label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants