Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed in redecorating ESPRESSO_PARALLEL_CMD with jobflow #2501

Open
yw-fang opened this issue Oct 17, 2024 · 2 comments
Open

Failed in redecorating ESPRESSO_PARALLEL_CMD with jobflow #2501

yw-fang opened this issue Oct 17, 2024 · 2 comments

Comments

@yw-fang
Copy link
Contributor

yw-fang commented Oct 17, 2024

What would you like to report?

This issue was raised from this discussion: #2491

The code to reproduce this issue:

from jobflow_remote import submit_flow
from jobflow import Flow
from ase.build import bulk
from quacc.recipes.espresso.core import relax_job
from quacc import change_settings
from quacc import job, redecorate

atoms = bulk('Cu')

espresso_parallel_cmd = ("srun --cpu_bind=cores", "-npool 2")
relax_job_ = redecorate(relax_job, job(settings_swap={"ESPRESSO_PARALLEL_CMD": espresso_parallel_cmd}))

job = relax_job_(atoms, relax_run=False)

flow = Flow(jobs=[job])

resources = {"nodes": 1, "partition": "general", "qos": "test" , "nodes": "1", "ntasks_per_node": "8"}

response = submit_flow(flow, worker='example_worker', resources=resources)
print(response)

The "-npool 2" in espresso_parallel_cmd was not passed to the remote HPC successfully. This issue could be caused by that jobflow also has a same decorator @job as quacc.

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Oct 17, 2024

Thanks for the report.

This issue could be caused by that jobflow also has a same decorator @job as quacc.

This is not the issue, as the quacc @job decorator becomes the jobflow @job decorator when the jobflow workflow engine is selected.

@yw-fang
Copy link
Contributor Author

yw-fang commented Oct 17, 2024

Thanks for the report.

This issue could be caused by that jobflow also has a same decorator @job as quacc.

This is not the issue, as the quacc @job decorator becomes the jobflow @job decorator when the jobflow workflow engine is selected.

Thanks for pointing it out. I will change the subject to avoid misleading.

@yw-fang yw-fang changed the title Potential conflict of job decorators between quacc and jobflow Failed in redecorating ESPRESSO_PARALLEL_CMD with jobflow Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants