Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Issues related to Benchmarks #53

Open
GiggleLiu opened this issue Jul 5, 2019 · 2 comments
Open

Issues related to Benchmarks #53

GiggleLiu opened this issue Jul 5, 2019 · 2 comments

Comments

@GiggleLiu
Copy link
Member

  • In primitive block benchmark, we should use put rather than repeat?
  • Do not use rand in this benchmark, please specify a deterministic position for benchmark.
@Roger-luo
Copy link
Member

No, the benchmark here is mainly to make sure that each block's apply is dispatched to correct function in certain context. The benchmark of instructions is in YaoArrayRegister. So in principle, we should have both, I just didn't write it in last PR. (I only set up the basic things)

Then specify a random seed?

@GiggleLiu
Copy link
Member Author

GiggleLiu commented Jul 5, 2019

Ok, I see. Then about random numbers, why not just specify two numbers to provide better readability?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants