Skip to content

Qubes Global Config: whonix UpdateVM can be set to "None" #10294

@deeplow

Description

@deeplow

Qubes OS release

Qubes OS 4.2

Brief summary

In the global config tool, Whonix can be set to None:

Image

When this is set the policy in 50-config-updates then becomes broken because it gets target=None.

Steps to reproduce

  1. Open Qubes Global Config >> Updates (tab)
  2. Change Whonix updateVM to be None
  3. Apply

Expected behavior

It should get a deny policy (thus preventing updates in whonix-based templates) or the option to set it as None should be set as None. The later makes more sense for me, since the GUI tool is meant to help people with reasonably sane configuration. Fully disabling the UpdatesVM for Whonix feels like something nobody would normally want to achieve.

Actual behavior

Broken policy file in /etc/qubes/policy.d/50-config-updates.policy due to target=None:

# THIS IS AN AUTOMATICALLY GENERATED POLICY FILE.
# Any changes made manually may be overwritten by Qubes Configuration Tools.

qubes.UpdatesProxy	*	@tag:whonix-updatevm	@default	allow target=None
qubes.UpdatesProxy	*	@type:TemplateVM	@default	allow target=sys-firewall

Additional information

I believe the problematic code is this line, which enters python's None directly into the policy file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C: Qubes GUI toolsThis issue pertains to Qubes GUI tools such as the Qube Manager and Qubes widgets.C: WhonixThis issue pertains to Whonix templates or standalones.P: defaultPriority: default. Default priority for new issues, to be replaced given sufficient information.affects-4.2This issue affects Qubes OS 4.2.community templateThis issue pertains to a community-maintained template.needs diagnosisRequires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions