Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom0 widget-wrapper error/traceback during dispvm cleanup #9358

Closed
rocodes opened this issue Jul 17, 2024 · 2 comments
Closed

dom0 widget-wrapper error/traceback during dispvm cleanup #9358

rocodes opened this issue Jul 17, 2024 · 2 comments
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@rocodes
Copy link

rocodes commented Jul 17, 2024

How to file a helpful issue

Qubes OS release

4.2.2

Brief summary

In the dom0 journal I notice a Python traceback pointing here when dispvms are cleaned up. I initially noticed this when the VM shuts down prematurely (eg, trying to open a file in a dispvm that doesn't have an appropriate mime handler), but this also occurs in normal shutdown of dispvm and I observe it every time.

Steps to reproduce

Start then shut down a disposable vm while watching dom0 journal

Expected behavior

Clean shutdown

Actual behavior

Jul 17 16:30:56 dom0 widget-wrapper[15776]: Failed to handle event: None, domain-delete, {'vm': 'disp5303'}
Jul 17 16:30:56 dom0 widget-wrapper[15776]: Traceback (most recent call last):
Jul 17 16:30:56 dom0 widget-wrapper[15776]:   File "/usr/lib/python3.11/site-packages/qubesadmin/events/__init__.py", line 259, in handle
Jul 17 16:30:56 dom0 widget-wrapper[15776]:     handler(subject, event, **kwargs)
Jul 17 16:30:56 dom0 widget-wrapper[15776]:   File "/usr/lib/python3.11/site-packages/qui/tray/updates.py", line 173, in domain_removed
Jul 17 16:30:56 dom0 widget-wrapper[15776]:     if vm.name in self.obsolete_vms:
Jul 17 16:30:56 dom0 widget-wrapper[15776]:        ^^^^^^^
Jul 17 16:30:56 dom0 widget-wrapper[15776]: AttributeError: 'str' object has no attribute 'name'
Jul 17 16:30:56 dom0 qubesd[13154]: Removing appmenus for 'disp5303' in 'dom0'
@rocodes rocodes added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jul 17, 2024
@marmarek
Copy link
Member

There is already fix for it here: QubesOS/qubes-desktop-linux-manager#210

@andrewdavidwong andrewdavidwong added C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). affects-4.2 This issue affects Qubes OS 4.2. pr submitted A pull request has been submitted for this issue. labels Jul 18, 2024
@andrewdavidwong
Copy link
Member

Closing as completed. If anyone believes this issue is not yet completed, or if anyone is still affected by this issue, please leave a comment, and we'll be happy to reopen it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

3 participants