Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suggests: for conditional dependencies #25

Open
s-u opened this issue Mar 19, 2022 · 1 comment
Open

Add Suggests: for conditional dependencies #25

s-u opened this issue Mar 19, 2022 · 1 comment
Assignees

Comments

@s-u
Copy link
Member

s-u commented Mar 19, 2022

Some dependencies are optional, so they should be declared in Suggests:. This is not important for the builds, but it is important for the new dependency resolution system since we need to know if an optional library has been used during the build. At the time of manifest generation we need to check whether suggested packages are also present and add them to BuiltWith:.

This will solve issues like FreeType's optional dependency on Harfbuzz (see #23)

@s-u s-u self-assigned this Mar 19, 2022
@s-u
Copy link
Member Author

s-u commented Oct 15, 2023

It is now implemented in a0488a8 such that BuiltWith is conditionally updated. However, build cycles have to be broken by hand, i.e. there is no automated bootstrap + re-build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant