Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseLinkHeader cannot parse multiple link values if the values are not separated by comma-space #165

Open
ashleysommer opened this issue Jun 24, 2024 · 0 comments · May be fixed by #166
Open

parseLinkHeader cannot parse multiple link values if the values are not separated by comma-space #165

ashleysommer opened this issue Jun 24, 2024 · 0 comments · May be fixed by #166

Comments

@ashleysommer
Copy link
Contributor

This line here assumes link values in the Link Header will be separated by comma-space.

prez-ui/src/composables/api.ts

Line 63 in 067ab41

const links = link.split(", ").map(l => parseLinkHeader(l));

However some HTTP servers will remove spaces between multiple header values. The values will be separated by comma without a space. In this case, prez-ui throws "currentProfile is undefined" because it cannot get correctly read the available profiles from the Link header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More lenient HTTP Link Header parsing, for different HTTP server compatibility RDFLib/prez-ui
1 participant
@ashleysommer