Compiler warnings for g++13.1

[torrance]

When compiling with -Wpendantic, g++ 13.1 emits the following warnings when simply including hip/hip_runtime.h:

g++ --std=c++17 playground.cpp -Wall -Wextra -Wpedantic -o playground -I/opt/rocm/include --D__HIP_PLATFORM_HCC__= -D__HIP_PLATFORM_AMD__=
In file included from /opt/rocm/include/hip/amd_detail/amd_channel_descriptor.h:28,
                 from /opt/rocm/include/hip/channel_descriptor.h:32,
                 from /opt/rocm/include/hip/texture_types.h:38,
                 from /opt/rocm/include/hip/hip_runtime_api.h:489,
                 from /opt/rocm/include/hip/hip_runtime.h:113,
                 from playground.cpp:3:
/opt/rocm/include/hip/amd_detail/amd_hip_vector_types.h:152:20: warning: ISO C++ prohibits anonymous structs [-Wpedantic]
  152 |             struct {
      |                    ^
/opt/rocm/include/hip/amd_detail/amd_hip_vector_types.h:187:20: warning: ISO C++ prohibits anonymous structs [-Wpedantic]
  187 |             struct {
      |                    ^
/opt/rocm/include/hip/amd_detail/amd_hip_vector_types.h:368:20: warning: ISO C++ prohibits anonymous structs [-Wpedantic]
  368 |             struct {
      |                    ^
/opt/rocm/include/hip/amd_detail/amd_hip_vector_types.h:411:20: warning: ISO C++ prohibits anonymous structs [-Wpedantic]
  411 |             struct {

[cjatin]

We want to fix it but it might require a some work and restructuring of code inorder to preserve API/ABI compatibility.

For now can you use something like:

#pragma GCC diagnostic ignored "-Wpedantic"
#include <hip/hip_runtime.h>
#pragma GCC diagnostic pop

[ppanchad-amd]

@torrance Can you please test with latest ROCm 6.1.0 (HIP 6.1)? If resolved, please close ticket. Thanks!

[ppanchad-amd]

@torrance Closing ticket for now. Please feel free to re-open ticket if you still see the issue with the latest ROCm. Thanks!

[IMbackK]

this is still a problem as can easly be seen by looking at the header in question. Even in rocm 6.3 this problem still exits:
https://github.com/ROCm/clr/blob/0d4823ff880947ec3f5818101e0e32b5889de175/hipamd/include/hip/amd_detail/amd_hip_vector_types.h#L153

[IMbackK]

@ppanchad-amd please reopen this issue

[ppanchad-amd]

Hi @IMbackK. Re-opened ticket and assigned for investigation. Thanks!

[wme7]

I'm observing this warning with HIP 6.2.4 too!

[ppanchad-amd]

@IMbackK

Error not seen with latest amd-staging HIP. Please confirm

➜ build git:(a01134a1a) cat play.cpp
#include <hip/hip_runtime.h>
int main() {}
➜ build git:(a01134a1a) g++ play.cpp -std=c++17 -Wall -Wextra -Wpedantic -I ./install/include -D__HIP_PLATFORM_HCC__=1 -D__HIP_PLATFORM_AMD__=1

[IMbackK]

indeed this issue was fixed by ROCm/clr@3cd3b3f