[Issue]: DBUILD_SHARED=ON still build libhsakmt.a

[ggankhuy]

Problem Description

From ROCR root dir:

mkdir build ; cd build ; cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_PREFIX_PATH=$CONFIG_INSTALL_PREFIX -DIMAGE_SUPPORT=OFF" .. ; make -j
find . -name "libhsakmt.*" // will find libhsakmt.a

1. Tried adding this to CMakeLists.txt: but no difference:
   +set(THUNK_DEFINITIONS "BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS}")
2. also tried building libhsakmt folder directly but also did not generate shared library but static one:

pushd libhsakmt ; mkdir build ; cd build
sudo cmake -DBUILD_SHARED_LIBS=ON ..
make -j (still libhsakmt.a)

Operating System

rhel9/centos9

CPU

epyc

GPU

mi250

ROCm Version

rocm6.2

ROCm Component

ROCR-Runtime

Steps to Reproduce

From ROCR root dir:

mkdir build ; cd build ; cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_PREFIX_PATH=$CONFIG_INSTALL_PREFIX -DIMAGE_SUPPORT=OFF" .. ; make -j
find . -name "libhsakmt.*" // will find libhsakmt.a

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

_No response_

### Additional Information

_No response_

[ggankhuy]

made two following changes in libhsakmt/CMakeListst.txt and now it works:

1. set c/c++ compiler for hipcc
2. do not explicitly add as static (add_library):

--- a/libhsakmt/CMakeLists.txt
+++ b/libhsakmt/CMakeLists.txt
@@ -26,6 +26,8 @@
 cmake_minimum_required ( VERSION 3.6.3 )

 set(CMAKE_VERBOSE_MAKEFILE ON)
 set ( HSAKMT "hsakmt" )
 set ( HSAKMT_PACKAGE "hsakmt-roct" )
@@ -37,7 +39,11 @@ project ( ${HSAKMT_TARGET} VERSION 1.9.0)

 # Build thunk as static by default
 if ( NOT DEFINED BUILD_SHARED_LIBS )
   set ( BUILD_SHARED_LIBS "off" )
 endif()
 set ( BUILD_SHARED_LIBS ${BUILD_SHARED_LIBS} CACHE BOOL "Build shared library (.so) or not.")

@@ -105,8 +111,10 @@ if ( ${ADDRESS_SANITIZER} )
     set ( HSAKMT_C_FLAGS "${HSAKMT_C_FLAGS}" -fsanitize=address )
     set ( HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS} -fsanitize=address" )
     if ( BUILD_SHARED_LIBS )
         set ( HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS} -shared-libsan" )
     else ()
         set ( HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS} -static-libsan" )
     endif ()
 else ()
@@ -137,7 +145,8 @@ set ( HSAKMT_SRC "src/debug.c"
                  "src/pc_sampling.c")

 ## Declare the library target name
-add_library (${HSAKMT_TARGET} STATIC "")
+add_library (${HSAKMT_TARGET} "")

[kentrussell]

Thunk is static, it is not designed to be built as shared anymore. What do you need it to be shared for?

[ggankhuy]

This jsut happened to be *.so file I looked into other issue. I can try looking into other issue using *.a file but result likely same.
Setting compiler caused some inf loop during cmake so I removed all then except add_library.

[ggankhuy]

If I do static, it masks the other issue (#300) even further. there is no rpm or debian package created.