Skip to content

Commit 2342567

Browse files
committed
gdb.rocm/watchpoint-at-end-of-shader: remove use of hip_devices_support_precise_memory
Make the gdb.rocm/watchpoint-at-end-of-shader.exp test not rely on hip_devices_support_precise_memory as this helper function will be removed. Change-Id: I25d32a68158e37f8821a03cf03618a41456af42d
1 parent 84c89ae commit 2342567

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

gdb/testsuite/gdb.rocm/watchpoint-at-end-of-shader.exp

+20-1
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,28 @@ proc do_test {precise_memory has_xfail} {
7777
}
7878
}
7979

80-
set supports_precise_memory [hip_devices_support_precise_memory]
8180
set has_xfail [target_has_xfail]
8281

82+
# First check if we support precise-memory.
83+
set supports_precise_memory 0
84+
clean_restart $::binfile
85+
with_rocm_gpu_lock {
86+
if {![runto_main]} {
87+
return
88+
}
89+
90+
gdb_test_multiple "set amdgpu precise-memory on" "" {
91+
-re -wrap "warning: AMDGPU precise memory access reporting could not be enabled\\." {
92+
set supports_precise_memory 0
93+
pass $gdb_test_name
94+
}
95+
-re -wrap "^" {
96+
set supports_precise_memory 1
97+
pass $gdb_test_name
98+
}
99+
}
100+
}
101+
83102
foreach_with_prefix precise_memory {on off} {
84103
if { $precise_memory && !$supports_precise_memory } {
85104
unsupported "target does not support precise memory"

0 commit comments

Comments
 (0)