-
Notifications
You must be signed in to change notification settings - Fork 570
cleanup and clarification of unified/managed memory docs #3819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, I don't have access to approving PRs here. I've invited @randyh62 to also take a look |
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
docs/how-to/hip_runtime_api/memory_management/unified_memory.rst
Outdated
Show resolved
Hide resolved
@briankoco Is there a reason why this was closed instead of it being merged in? Should we prepare a PR from our side with your changes? |
I believe the changes have been merged. Github was not allowing me to merge, with an error about the branch being unable to rebase due to conflicts. I followed the command line approach of checking out |
Ah okay, I see the commits in docs/develop now |
Associated JIRA ticket number/Github issue number
N/A
What type of PR is this? (check all applicable)
What were the changes?
hipHostRegister()
managed memory table entriesWhy are these changes needed?
Some of the unified memory documentation is incorrect, and performance implications of managed memory were not sufficiently captured
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks