Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] rsx: Fix hacky stencil mirror samplers #16438

Open
kd-11 opened this issue Dec 20, 2024 · 2 comments
Open

[Task] rsx: Fix hacky stencil mirror samplers #16438

kd-11 opened this issue Dec 20, 2024 · 2 comments
Assignees

Comments

@kd-11
Copy link
Contributor

kd-11 commented Dec 20, 2024

These are really hacky right now. A proper implementation should be added taking advantage of custom border colors and clamping modes.

@digant73
Copy link
Contributor

is this task related to some reported bugs/broken features or just an improvement/better code implementation?

@kd-11
Copy link
Contributor Author

kd-11 commented Dec 22, 2024

is this task related to some reported bugs/broken features or just an improvement/better code implementation?

More of "I can't believe this is still in the code, no idea how many games are broken by it".
It's one of those subtle things though, so in practice maybe just creates broken shadows in some games or some other broken effects. The technique is mostly used in postprocessing shaders anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants