Linking error on Windows 11 compiling RCPS3 in DEBUG mode with latest llvm 19.1.7

[digant73]

Quick summary

As reported in #16620, with LLVM 19.1.7, it is no more possible to compile RPCS3 in DEBUG mode under Windows 11 (compiling from VS2022).
The following errors are returned at linking phase:

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK2005	"public: __cdecl llvm::PredicateInfo::~PredicateInfo(void)" (??1PredicateInfo@llvm@@QEAA@XZ) already defined in LLVMTableGenCommon.lib(CodeGenTarget.cpp.obj)	rpcs3	M:\console\git\rpcs3_diga\rpcs3\LLVMTransformUtils.lib(PredicateInfo.cpp.obj)	1		
Error	LNK1169	one or more multiply defined symbols found	rpcs3	M:\console\git\rpcs3_diga\bin\rpcs3d.exe	1		

Details

No response

Attach a log file

no file due to issue type

Attach capture files for visual issues

No response

System configuration

No response

Other details

No response

[Darkhost1999]

What I'm seeing is when compiling debug mode MSVC is using libcmt.lib and libcmtd.lib mixing release and debug libraries.

[digant73]

Compilation environment should be checked and eventually fixed. To compile in DEBUG mode I have to remove LLVMTableGenCommon.lib in rpcs3_debug.props. However, after I'm able to compile I got different runtime errors (assert failure) when starting any game. One is due to array out of bounds (error in xutility MSVC shared .h). Changing the code in xutility I then get another assert failure on jit). It seems there is no interest on fixing/using debugging so just avoiding to open further bug reports on that topic

[cipherxof]

Same issue with LLVM 20.1.1

[NefariousTechSupport]

A quick hacky fix for this would be to add the following line just before the declaration of struct PredicateInfo in CodeGenSchedule.h

#define PredicateInfo PredicateInfo2

It appears that the PredicateInfo struct declared there is conflicting with the PredicateInfo class declared in PredicateInfo.h

[digant73]

@NefariousTechSupport thanks but there are still other errors on logitechg27 and rpcs3_test modules.

I also needed to change the following line in hid_pad_handler.h

inline constexpr auto hid_enumerated_device_default = std::string();

to

inline /*constexpr*/ auto hid_enumerated_device_default = std::string();

[NefariousTechSupport]

That's odd, I don't have that issue. I'm using VS2022 and on Windows 11 like you, but if that works for you then so long as you don't commit it you should be fine.

[digant73]

it doesn't work. That line changed is mandatory to avoid compile error.
But after changing that then I got linking error on those mentioned modules.
I'm also on VS2022 (even reinstalled from scratch)