[Regression] Crash when loading game list after ISO support (#18008)

[5kft]

Quick summary

The "Full decrypted ISO support" changes in Windows build 0.0.39-18648 cause "RPCS3: Fatal Error" assertions at launch of RPCS3; can no longer launch RPCS3 successfully

Details

I launched RPCS3 and was prompted to upgrade to the new version 0.0.39-18648 (including the ISO support changes). I upgraded, and when RPCS3 restarted, it displays two "Verification failed" assertion errors in File.cpp:567. After pressing OK on both assertion dialogs, RPCS3 exits. Launching RPCS3 again gives the same Fatal Error dialogs. After downgrading to the prior Windows build 0.0.39-18623, I can successfully launch and use RPCS3 again.

Here is a screenshot of RPCS3 showing the two assertion dialogs:

Build with regression

v0.0.39-18648-49bcc930

Attach two log files

RPCS3-0.0.39-18648-crash.log.gz

RPCS3-0.0.39-18623-works.log.gz

Attach capture files for visual issues

No response

System configuration

No response

Other details

No response

[5kft]

In case it is helpful, as a test I added some logging in the "size()" function in File.cpp, and GetLastError() following the "GetFileSizeEx(m_handle, &size)" failure returns 0x1 (ERROR_INVALID_FUNCTION) for both of these failure asserts. filetype=0x1 is FILE_TYPE_DISK.

I tried querying the associated filename for the handle from "m_handle" via GetFinalPathNameByHandleW(), but the result is empty; see the "FS" error log messages here, "gle" is the return value from GetLastError():

As a test, I tweaked "size()" to ignore the error (i.e., don't assert) for this "ERROR_INVALID_FUNCTION" failure case, and RPCS3 starts up and runs just fine.

At this point I don't know if these two handles are stale/closed/what but something in the set of ISO changes appears to impact something odd at startup now...

[xperia64]

This issue appears to occur if:

1. You previously added the root of a drive letter to rpcs3's config/games.yml (e.g. when mounting an ISO in Windows)
2. The drive letter now corresponds to empty removable storage (e.g. an empty SD card reader)

Removing the entry from games.yml works around the issue.

Paths/drive letters that no longer exist do not seem to trigger this issue, only drive letters that correspond to an empty device.

[5kft]

Thanks @xperia64 , I can confirm that this workaround for the regression works.

[digant73]

regressed by #17855