Build broken since glew 2.3.0 due to NamedBufferStorageEXT removal

[rubin55]

Quick summary

...
[ 76%] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/VK/upscalers/fsr1/fsr_pass.cpp.o
[ 76%] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/VK/vkutils/barriers.cpp.o
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/buffer_object.cpp:47:4: error:
      use of undeclared identifier 'glNamedBufferStorageEXT'; did you mean
      '__glewBufferStorageEXT'?
   47 |                         DSA_CALL2(NamedBufferStorage, m_id, size, data_, flags);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/common.h:39:3: note:
      expanded from macro 'DSA_CALL2'
   39 |                 gl##func##EXT(__VA_ARGS__);
      |                 ^~~~~~~~~~~~~
<scratch space>:760:1: note: expanded from here
  760 | glNamedBufferStorageEXT
      | ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/GL/glew.h:24223:43: note:
      '__glewBufferStorageEXT' declared here
 24223 | GLEW_FUN_EXPORT PFNGLBUFFERSTORAGEEXTPROC __glewBufferStorageEXT;
       |                                           ^
[ 76%] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/VK/vkutils/buffer_object.cpp.o
[ 76%] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/VK/vkutils/chip_class.cpp.o
[ 76%] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/VK/vkutils/commands.cpp.o
1 error generated.
make[2]: *** [rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/build.make:6225: rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/GL/glutils/buffer_object.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/ring_buffer.cpp:20:3: error:
      use of undeclared identifier 'glNamedBufferStorageEXT'; did you mean
      '__glewBufferStorageEXT'?
   20 |   ...DSA_CALL2(NamedBufferStorage, m_id, size, data, buffer_storage_flags);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/common.h:39:3: note:
      expanded from macro 'DSA_CALL2'
   39 |                 gl##func##EXT(__VA_ARGS__);
      |                 ^~~~~~~~~~~~~
<scratch space>:775:1: note: expanded from here
  775 | glNamedBufferStorageEXT
      | ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/GL/glew.h:24223:43: note:
      '__glewBufferStorageEXT' declared here
 24223 | GLEW_FUN_EXPORT PFNGLBUFFERSTORAGEEXTPROC __glewBufferStorageEXT;
       |                                           ^
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/ring_buffer.cpp:209:3: error:
      use of undeclared identifier 'glNamedBufferStorageEXT'; did you mean
      '__glewBufferStorageEXT'?
  209 |   ...DSA_CALL2(NamedBufferStorage, m_id, size, data, GL_MAP_WRITE_BIT);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/makepkg.builddir/rpcs3-git/src/rpcs3/rpcs3/Emu/RSX/GL/glutils/common.h:39:3: note:
      expanded from macro 'DSA_CALL2'
   39 |                 gl##func##EXT(__VA_ARGS__);
      |                 ^~~~~~~~~~~~~
<scratch space>:7:1: note: expanded from here
    7 | glNamedBufferStorageEXT
      | ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/GL/glew.h:24223:43: note:
      '__glewBufferStorageEXT' declared here
 24223 | GLEW_FUN_EXPORT PFNGLBUFFERSTORAGEEXTPROC __glewBufferStorageEXT;
       |                                           ^
2 errors generated.
make[2]: *** [rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/build.make:6309: rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/RSX/GL/glutils/ring_buffer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3177: rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

Details

I build rpcs3-git daily, the above showed up this morning.

Attach a log file

No log file, see description body.

Attach capture files for visual issues

No response

System configuration

Arch Linux

Other details

No response

[AniLeo]

Can't reproduce on Manjaro, just built rpcs3-git fine

[digant73]

@rubin55 maybe you forgot to update submodules?

[AniLeo]

gl is not related to that, and it's rarely updated anyways. It's from a system package change.

[engdyn]

The update of glew from 2.2.0 to 2.3.0 is the reason the build is failing. I downgraded back to glew 2.2.0 and everything was building fine again. But that seems to be a bigger issue because NamedBufferStorageEXT got removed from the OpenGL specifications. See nigels-com/glew#454 and KhronosGroup/OpenGL-Registry#646

[AniLeo]

because NamedBufferStorageEXT got removed from the OpenGL specifications

what the hell...

[kd-11]

The only solution here is to completely drop support of EXT_DSA.

[AniLeo]

glew 2.3.1 should ship with a fix for this, however, it means rpcs3 won't compile on glew 2.3.0 for the time being (rpcs3-git AUR is effectively broken), plus drivers can change their implementation following the spec change and introduce issues

[kd-11]

I'll come up with a smaller workaround in the mean time to just use bindful access. I can't remember which cards only had EXT_DSA without ARB_DSA.

[hackcr1258]

I can reproduce this issue. App image works fine tho
I am using Arch with the latest updates

[kd-11]

Looks like glew added it back so we don't need any interim hacks.