Fix #69

Description:
- Add a bandaid for some gcov/build system issue where sometimes empty gcno/gcda crop up
- Create new exit code 8 if this happens

Author: RPGillespie6

fastcov.py

@@ -50,6 +50,7 @@
     "unsupported_coverage_format": 5,
     "excl_not_found": 6,
     "bad_chunk_file": 7,
+    "missing_json_key": 8,
 }
 
 # Disable all logging in case developers are using this as a module
@@ -272,7 +273,12 @@ def gcovWorker(data_q, metrics_q, args, chunk, gcov_filter_options):
         except json.decoder.JSONDecodeError as e:
             logging.error("Could not process chunk file '{}' ({}/{})".format(chunk[i], i+1, len(chunk)))
             logging.error(str(e))
-            error_exit = True
+            setExitCode("bad_chunk_file")
+            continue
+
+        if "current_working_directory" not in intermediate_json:
+            logging.error("Missing 'current_working_directory' for data file: {}".format(intermediate_json))
+            setExitCode("missing_json_key")
             continue
 
         intermediate_json_files = processGcovs(args.cdirectory, intermediate_json["files"], intermediate_json["current_working_directory"], gcov_filter_options)
@@ -285,8 +291,7 @@ def gcovWorker(data_q, metrics_q, args, chunk, gcov_filter_options):
     data_q.put(base_report)
     metrics_q.put((gcovs_total, gcovs_skipped))
 
-    if error_exit:
-        sys.exit(1)
+    sys.exit(EXIT_CODE)
 
 def processGcdas(args, coverage_files, gcov_filter_options):
     chunk_size = max(args.minimum_chunk, int(len(coverage_files) / args.jobs) + 1)
@@ -309,7 +314,7 @@ def processGcdas(args, coverage_files, gcov_filter_options):
     for p in processes:
         p.join()
         if p.exitcode != 0:
-            setExitCode("bad_chunk_file")
+            setExitCodeRaw(p.exitcode)
 
     base_fastcov = fastcov_jsons.pop()
     for fj in fastcov_jsons:

test/functional/run_all.sh

@@ -207,6 +207,12 @@ cat print_coverage.info.log | grep 'Lines Coverage: 60.00%, 9/15'
 coverage run -a ${TEST_DIR}/fastcov.py -C ${TEST_DIR}/expected_results/diff_filter_data/basic.json --diff-filter ${TEST_DIR}/expected_results/diff_filter_data/exclude_each_item.diff --diff-base-dir /mnt/workspace -o exclude_each_item.actual.json
 ${TEST_DIR}/json_cmp.py exclude_each_item.actual.json ${TEST_DIR}/expected_results/diff_filter_data/exclude_each_item.expected.json
 
+# Test (empty gcno)
+touch empty.gcno
+rc=0
+coverage run -a ${TEST_DIR}/fastcov.py --gcov gcov-9 --process-gcno || rc=$?
+test $rc -eq 8
+
 # Write out coverage as xml
 coverage combine
 coverage xml -o coverage.xml