Attempt to invoke virtual method 'java.io.InputStream java.net.Socket.getInputStream()' on a null object reference

[sergeushenecz]

Hello everyone. I see in the sentry sometimes this errors. Maybe someone are faced also with this issues?

[marianolc]

This is a bug(i think) that i "fixed" in the version I forked... i just changed the write() method in TcpSocketClient:

public void write(final int msgId, final byte[] data) {
        writeExecutor.execute(new Runnable() {
            @Override
            public void run() {
               // THIS IS THE FIX VALIDATION ***********************
                if (socket == null) {
                    receiverListener.onError(getId(), new IOException("Attempted to write to closed socket"));
                    return;
                }
                try {
                    socket.getOutputStream().write(data);
                    receiverListener.onWritten(getId(), msgId, null);
                } catch (IOException e) {
                    receiverListener.onWritten(getId(), msgId, e);
                    receiverListener.onError(getId(), e);
                }
            }
        });
    }

[sergeushenecz]

And this code will fix problem? Maybe need to add pull request for it?

[sergeushenecz]

@marianolc I've checked in library and see the same code as you wrote me. I don't understand where need to add fix.

[hakansaglam29]

    @Override
    public void run() {
        int socketId = clientSocket.getId();
        Socket socket = clientSocket.getSocket();
        byte[] buffer = new byte[16384];
        try {
            BufferedInputStream in = new BufferedInputStream(socket.getInputStream());
            while (!socket.isClosed()) {
                int bufferCount = in.read(buffer);
                waitIfPaused();
                if (bufferCount > 0) {
                    receiverListener.onData(socketId, Arrays.copyOfRange(buffer, 0, bufferCount));
                } else if (bufferCount == -1) {
                    clientSocket.destroy();
                }
            }
        } catch (IOException | InterruptedException ioe) {
            if (receiverListener != null && !socket.isClosed() && !clientSocket.closed) {
                receiverListener.onError(socketId, ioe);
            }
        }
    }

why try catch is not working here?

[hakansaglam29]

@Override
public void run() {
    int socketId = clientSocket.getId();
    Socket socket = clientSocket.getSocket();

     if (socket == null) {
            return;
     }

    byte[] buffer = new byte[16384];
    try {
        BufferedInputStream in = new BufferedInputStream(socket.getInputStream());
        while (!socket.isClosed()) {
            int bufferCount = in.read(buffer);
            waitIfPaused();
            if (bufferCount > 0) {
                receiverListener.onData(socketId, Arrays.copyOfRange(buffer, 0, bufferCount));
            } else if (bufferCount == -1) {
                clientSocket.destroy();
            }
        }
    } catch (IOException | InterruptedException ioe) {
        if (receiverListener != null && !socket.isClosed() && !clientSocket.closed) {
            receiverListener.onError(socketId, ioe);
        }
    }
}

I will add socket == null condition and try?