Summarize original script issues

[brunob]

Following #27 (comment) let's try to summarize issues of original script that are still valid :

• Not working in SamsungBrowser elmarquis/Leaflet.GestureHandling#2 => outdated
• 2 finger drag problem Android elmarquis/Leaflet.GestureHandling#8 => seems too specific
• This result in draw problem for leaflet.draw of rectangle. The mouse seem like stick to the map when i am trying to draw the rectangle by expand it area.This problem happen after drawn polygon. elmarquis/Leaflet.GestureHandling#10 seems related to please add an option to disable/enable the option dynamically elmarquis/Leaflet.GestureHandling#31
• When dragging the map, dragging stops if the mouse moves over a marker or polygon. elmarquis/Leaflet.GestureHandling#11 => should be closed cf When dragging the map, dragging stops if the mouse moves over a marker or polygon. elmarquis/Leaflet.GestureHandling#11 (comment)
• Incorrect behaviour when used with Marker Cluster plugin. elmarquis/Leaflet.GestureHandling#14 => check needed
• Load language file over ajax elmarquis/Leaflet.GestureHandling#17
• Problem in Android devices elmarquis/Leaflet.GestureHandling#20
• Please add text-align:center to text overlay elmarquis/Leaflet.GestureHandling#34
• Feature Request integration with ngx-leaflet elmarquis/Leaflet.GestureHandling#35
• Allow language to be set via option elmarquis/Leaflet.GestureHandling#36
• Add some fading-out to warning overlay elmarquis/Leaflet.GestureHandling#40
• Can't drag map after mouseover circle marker elmarquis/Leaflet.GestureHandling#44 => check needed
• Interactions stay disabled after touching an ignored element elmarquis/Leaflet.GestureHandling#46 => check needed
• i18n: gestureHandlingOptions > text not working elmarquis/Leaflet.GestureHandling#47
• Map reinitialization causes an error on drag elmarquis/Leaflet.GestureHandling#49 => check needed
• Ctrl + scroll on popup zooms the whole page elmarquis/Leaflet.GestureHandling#52
• Warning message does not disappear under shadow DOM  elmarquis/Leaflet.GestureHandling#53 => seems fixed
• Overlay only visible as small bar on the left elmarquis/Leaflet.GestureHandling#60
• two finger drag / page scroll prevention and glitchy panning elmarquis/Leaflet.GestureHandling#65 => fixed On mobile, zooming in/out will zoom in/out on browser too #11
• Lighthouse error "passive listeners" elmarquis/Leaflet.GestureHandling#66
• Map sometimes not draggable when reloading the Website elmarquis/Leaflet.GestureHandling#75 => check needed
• Cannot read property 'duration' of undefined elmarquis/Leaflet.GestureHandling#76 => seems fixed
• Touch on map buttons triggers the default behavior elmarquis/Leaflet.GestureHandling#85
• Wrong default language - WCAG 3.1.2 failure elmarquis/Leaflet.GestureHandling#86
• How to enable fadeout for the message elmarquis/Leaflet.GestureHandling#88
• German macOS Translation is empty elmarquis/Leaflet.GestureHandling#95

@Raruto feel free to amend this list if i've checked some issues that are not really fixed :)

[Raruto]

elmarquis/Leaflet.GestureHandling#14

@hupe13 Do you use that? Has it ever given you any problems?

---

elmarquis/Leaflet.GestureHandling#31

@brunob It's one of the few 3rd party plugins (that I use) that I didn't develop myself :)

leaflet-gesture-handling/src/index.js

Lines 283 to 291 in d2e0a39

	_onExitFullscreen: function() {
	if (this._map.options.gestureHandling)
	this._map.gestureHandling.enable();
	},
	_onEnterFullscreen: function() {
	if (this._map.options.gestureHandling)
	this._map.gestureHandling.disable();
	},

---

elmarquis/Leaflet.GestureHandling#11

@brunob I honestly don't remember, at that time I think I had solved many of these things:

leaflet-gesture-handling/src/index.js

Lines 201 to 220 in d2e0a39

	_handleTouch: function(e) {
	//Disregard touch events on the controls and popups if present
	var ignore = L.DomUtil.hasClass(e.target, "leaflet-interactive") || e.target.closest('.leaflet-control-container') || e.target.closest('.leaflet-popup-pane');
	if (ignore) {
	if (L.DomUtil.hasClass(e.target, "leaflet-interactive") && e.type === "touchmove" && e.touches.length === 1) {
	this._enableTouchWarning();
	} else {
	this._disableTouchWarning();
	}
	} else if (e.type !== "touchmove" && e.type !== "touchstart") {
	this._disableTouchWarning();
	} else if (e.touches.length === 1) {
	this._enableTouchWarning();
	} else {
	e.preventDefault();
	this._disableTouchWarning();
	this._enableInteractions();
	}
	},

leaflet-gesture-handling/src/index.js

Lines 270 to 273 in d2e0a39

	_handleScrollOnPopup: function(e) {
	L.DomEvent[e.type == 'popupopen' ? 'on' : 'off']
	(e.popup._contentNode, "wheel", this._handleScroll, this);
	},

See also: https://raruto.github.io/leaflet-gesture-handling/test/

[hupe13]

Do you use that? Has it ever given you any problems?

I don't have any problems with it. I tested it on Android just now. When you tap on a cluster to long (in the millisecond range), then a very small moment the message from GestureHandling appears sometimes. But you have to pay close attention to it, otherwise it won't be noticed.

Some users are very accurate, no one has ever complained. And I haven't noticed it so far.