Installing Plugins on RPI4/Bullseye on 3.3.0

[feh123]

Hi I thought maybe I was doing sometihng wrong. But I have repeated my attempt to install Firewall and I have had the same issue. I copied my terminal output and the final RaspAP GUI below:

pi@Extender:/var/www/html/plugins $ sudo git pull origin master
fatal: detected dubious ownership in repository at '/var/www/html/plugins'
To add an exception for this directory, call:
	git config --global --add safe.directory /var/www/html/plugins
pi@Extender:/var/www/html/plugins $ sudo git config --global --add safe.directory /var/www/html/plugins
pi@Extender:/var/www/html/plugins $ sudo git pull origin master
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint: 
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint: 
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
From https://github.com/RaspAP/plugins
 * branch            master     -> FETCH_HEAD
Updating 3833170..a427e53
Fast-forward
 manifest.json | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)
pi@Extender:/var/www/html/plugins $ 

Rebooted.
Everything seemed good and firewall was in the plugins list. I tried installing it but got:

An exception occurred
Stack trace:
Error: Call to undefined function RaspAP\Plugins\Firewall\str_starts_with()
 at RaspAP.Plugins.Firewall.Firewall.handlePageAction(Firewall.php:65)
 at RaspAP.Plugins.PluginManager.handlePageAction(PluginManager.php:86)
 at require_once(page_actions.php:10)
 at (main)(index.php:126)

The GUI is now frozen but the AP is still working! Luckily I always a have a cloned working sd card so my RaspAP is working. Is there something I am missing? Thanks!

[billz]

@feh123 the function str_starts_with() was introduced in PHP 8.0. Since you're running Bullseye with an older version (7.4), this function doesn't exist. A compatibility fix has been pushed. In the meantime, you can replace this line (Firewall.php:65) with:

// Verify that this plugin should handle the page
if (strpos($page, "/plugin__" . $this->getName()) === 0) {

[feh123]

@billz thanks. This is great.

[billz]

Sorry for the trouble. This applies to all plugins (and the SamplePlugin) so I appreciate you flagging this.

[feh123]

@billz I have just edited Firewall.php:65 and that unfroze the GUI and my hotspot is working (through Nordvpn). I can see the Firewall in the menu list and I can open it. On trying to enable the firewall I get the menu with the proceed button. But clicking this does nothing - icon colour changes from green briefly to blue then back to green. I wait but nothing happens and the firewall is not enabled. I tried adding the VPN address exception but it made no difference. As I recall this was usually fast but maybe I am missing something. Sorry for doing this on a Sunday! No rush.

[feh123]

Ah - I finally looked at the system tab. And there I see:

An exception occurred
Stack trace:

Error: Call to undefined function RaspAP\Plugins\str_contains()
at RaspAP.Plugins.PluginInstaller.getUserPlugins(PluginInstaller.php:81)
at DisplaySystem(system.php:118)
at handleCorePageAction(page_actions.php:59)
at require_once(page_actions.php:12)
at (main)(index.php:126)

[billz]

This is resolved in the latest v3.3.0 release.

[feh123]

Great! Thanks.