Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor/Projects theming tidy up #1026

Open
4 tasks
sra405 opened this issue May 29, 2024 · 0 comments
Open
4 tasks

Editor/Projects theming tidy up #1026

sra405 opened this issue May 29, 2024 · 0 comments

Comments

@sra405
Copy link
Contributor

sra405 commented May 29, 2024

The editor uses design tokens to apply themes for light mode, dark mode and projects.

The themes are largely defined in the editor's index.scss and the project site editor.scss but some themes are also defined at the component level (see, for example, the editor's tabs.scss).

It may be better to define all themes in a central file, which in the editor's case would also allow the standalone web component to receive a default theme through the InternalStyles.scss.

Fixes and issues

  • !important is being used in the editor's Buttons.scss to override a secondary border colour. Can this be avoided?
  • Editor's Tabs.scss doesn't apply themes consistent with Button.scss (ie, the button themes are defined in Index.scss). Review the tabs approach and make it consistent with the button
  • Editor.scss uses placeholder colours forrpf-files-list-item-active and rpf-files-list-item-hover: check with design what the correct colours should be
  • Dark mode tertiary button icons should be white
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant