Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyodide runner disabling react-hook/exhaustive-deps #920

Open
sra405 opened this issue Feb 12, 2024 · 0 comments
Open

Remove pyodide runner disabling react-hook/exhaustive-deps #920

sra405 opened this issue Feb 12, 2024 · 0 comments
Labels
tech debt

Comments

@sra405
Copy link
Contributor

sra405 commented Feb 12, 2024

⛏️ I'm not a fan of this rule for sure, especially with empty dependency arrays but 2/3 useEffects that are effected can have handleRun and handleStop in the array without any impact

Originally posted by @sra405 in #893 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sra405