fix: keep original dictionaries for dialogue

luiza.torello · luiza.torello · commit db16f12158dd · 2025-09-09T22:04:01.000-03:00
diff --git a/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Achievement/ExchangeQuestSo.cs b/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Achievement/ExchangeQuestSo.cs
@@ -40,7 +40,7 @@ public override void Init()
         {
             base.Init();
             ItemsToExchangeByType = new ItemAmountDictionary();
-            OriginalItemsToExchangeByType = ItemsToExchangeByType.Clone();
+            OriginalItemsToExchangeByType = (ItemAmountDictionary)ItemsToExchangeByType.Clone();
             Npc = null;
             HasItems = false;
             HasCreatedDialogue = false;
@@ -55,7 +55,7 @@ public override void Init(QuestSo copiedQuest)
             {
                 Npc = exchangeQuest.Npc;
                 ItemsToExchangeByType = (ItemAmountDictionary) exchangeQuest.ItemsToExchangeByType.Clone();
-                OriginalItemsToExchangeByType = ItemsToExchangeByType.Clone();
+                OriginalItemsToExchangeByType = (ItemAmountDictionary)ItemsToExchangeByType.Clone();
                 ExchangeData = exchangeQuest.ExchangeData;
                 HasItems = exchangeQuest.HasItems;
                 HasCreatedDialogue = exchangeQuest.HasCreatedDialogue;
@@ -72,7 +72,7 @@ public void Init( string questName, bool endsStoryLine, QuestSo previous, NpcSo
             base.Init(questName, endsStoryLine, previous);
             Npc = npc;
             ItemsToExchangeByType = exchangedItems;
-            OriginalItemsToExchangeByType = ItemsToExchangeByType.Clone();
+            OriginalItemsToExchangeByType = (ItemAmountDictionary)ItemsToExchangeByType.Clone();
             ExchangeData =
                 new ExchangeQuestData((ItemAmountDictionary) ItemsToExchangeByType.Clone(), receivedItem, Id);
             HasItems = false;
diff --git a/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Achievement/GatherQuestSo.cs b/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Achievement/GatherQuestSo.cs
@@ -23,7 +23,7 @@ public override void Init()
         {
             base.Init();
             ItemsToGatherByType = new ItemAmountDictionary();
-            OriginalItemsToGatherByType = ItemsToGatherByType.Clone();
+            OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();
         }
         
         public override void Init(QuestSo copiedQuest)
@@ -33,7 +33,7 @@ public override void Init(QuestSo copiedQuest)
             if (getQuest != null)
             {
                 ItemsToGatherByType = (ItemAmountDictionary) getQuest.ItemsToGatherByType.Clone();
-                OriginalItemsToGatherByType = ItemsToGatherByType.Clone();
+                OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();
             }
             else
             {
@@ -46,7 +46,7 @@ public void Init(string questName, bool endsStoryLine, QuestSo previous, ItemAmo
         {
             base.Init(questName, endsStoryLine, previous);
             ItemsToGatherByType = itemsByType;
-            OriginalItemsToGatherByType = ItemsToGatherByType.Clone();
+            OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();
         }
         
         public override QuestSo Clone()
diff --git a/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Mastery/KillQuestSo.cs b/Assets/Scripts/Game/NarrativeGenerator/Quests/ProfileQuests/Mastery/KillQuestSo.cs
@@ -29,14 +29,14 @@ public override void Init()
             base.Init();
             EnemiesToKillByType = new EnemiesByType();
             EnemiesToKillByFitness = new Dictionary<float, int>();
-            OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();
+            OriginalEnemiesToKillByType = new EnemiesByType();
         }
 
         public void Init(string questName, bool endsStoryLine, QuestSo previous, EnemiesByType enemiesByType)
         {
             base.Init(questName, endsStoryLine, previous);
             EnemiesToKillByType = enemiesByType;
-            OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();
+            OriginalEnemiesToKillByType = enemiesByType;
         }
         public void Init(string questName, bool endsStoryLine, QuestSo previous, Dictionary<float, int> enemiesByFitness)
         {
@@ -52,7 +52,7 @@ public override void Init(QuestSo copiedQuest)
             if (killQuest != null)
             {
                 EnemiesToKillByType.EnemiesByTypeDictionary = (WeaponTypeAmountDictionary) killQuest.EnemiesToKillByType.EnemiesByTypeDictionary.Clone();
-                OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();
+                OriginalEnemiesToKillByType.EnemiesByTypeDictionary = (WeaponTypeAmountDictionary) killQuest.EnemiesToKillByType.EnemiesByTypeDictionary.Clone();
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public override void Init()`
`23`	`23`	`{`
`24`	`24`	`base.Init();`
`25`	`25`	`ItemsToGatherByType = new ItemAmountDictionary();`
`26`		`- OriginalItemsToGatherByType = ItemsToGatherByType.Clone();`
	`26`	`+ OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`public override void Init(QuestSo copiedQuest)`
`@@ -33,7 +33,7 @@ public override void Init(QuestSo copiedQuest)`
`33`	`33`	`if (getQuest != null)`
`34`	`34`	`{`
`35`	`35`	`ItemsToGatherByType = (ItemAmountDictionary) getQuest.ItemsToGatherByType.Clone();`
`36`		`- OriginalItemsToGatherByType = ItemsToGatherByType.Clone();`
	`36`	`+ OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();`
`37`	`37`	`}`
`38`	`38`	`else`
`39`	`39`	`{`
`@@ -46,7 +46,7 @@ public void Init(string questName, bool endsStoryLine, QuestSo previous, ItemAmo`
`46`	`46`	`{`
`47`	`47`	`base.Init(questName, endsStoryLine, previous);`
`48`	`48`	`ItemsToGatherByType = itemsByType;`
`49`		`- OriginalItemsToGatherByType = ItemsToGatherByType.Clone();`
	`49`	`+ OriginalItemsToGatherByType = (ItemAmountDictionary)ItemsToGatherByType.Clone();`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`public override QuestSo Clone()`
Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,14 @@ public override void Init()`
`29`	`29`	`base.Init();`
`30`	`30`	`EnemiesToKillByType = new EnemiesByType();`
`31`	`31`	`EnemiesToKillByFitness = new Dictionary<float, int>();`
`32`		`- OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();`
	`32`	`+ OriginalEnemiesToKillByType = new EnemiesByType();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`public void Init(string questName, bool endsStoryLine, QuestSo previous, EnemiesByType enemiesByType)`
`36`	`36`	`{`
`37`	`37`	`base.Init(questName, endsStoryLine, previous);`
`38`	`38`	`EnemiesToKillByType = enemiesByType;`
`39`		`- OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();`
	`39`	`+ OriginalEnemiesToKillByType = enemiesByType;`
`40`	`40`	`}`
`41`	`41`	`public void Init(string questName, bool endsStoryLine, QuestSo previous, Dictionary<float, int> enemiesByFitness)`
`42`	`42`	`{`
`@@ -52,7 +52,7 @@ public override void Init(QuestSo copiedQuest)`
`52`	`52`	`if (killQuest != null)`
`53`	`53`	`{`
`54`	`54`	`EnemiesToKillByType.EnemiesByTypeDictionary = (WeaponTypeAmountDictionary) killQuest.EnemiesToKillByType.EnemiesByTypeDictionary.Clone();`
`55`		`- OriginalEnemiesToKillByType = EnemiesToKillByType.Clone();`
	`55`	`+ OriginalEnemiesToKillByType.EnemiesByTypeDictionary = (WeaponTypeAmountDictionary) killQuest.EnemiesToKillByType.EnemiesByTypeDictionary.Clone();`
`56`	`56`	`}`
`57`	`57`	`else`
`58`	`58`	`{`