Skip to content

bug: Entering an invalid patches source url shows a confusing error message #2792

@LisoUseInAIKyrios

Description

@LisoUseInAIKyrios

Bug description

Bug description

  1. Add any invalid patch source such as https://github.com/non_existent_user!!11/huh or http://google.com/i_dont_understand_patches
  2. Manager shows an error toast with an un-intuitive error message
  3. Patch source in Manager shows an error icon
Image

This issue is similar but not the same issue as the lack of backwards compatible reported in #2788

Manager should show a more informative error message and it should not add the broken url as a patch source.

Version of ReVanced Manager and version & name of app you are patching

1.26.0-dev.7

Installation method

None

ReVanced Manager logs

ReVanced Manager: Failed to update patches
E ReVanced Manager: io.ktor.http.URLDecodeException: {"payload":{"allShortcutsEnabled":false,"path":"/","repo":{"id":766466597,"defaultBranch":"main","name":"privacy-revanced-patches","ownerLogin":"jkennethcarino"

Patch logs

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug reportSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions