Skip to content

fix: CI flows #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: compose-dev
Choose a base branch
from
Open

fix: CI flows #2598

wants to merge 5 commits into from

Conversation

brosssh
Copy link
Member

@brosssh brosssh commented Jun 5, 2025

?(.asc) is not supported in GitHub actions (I think). Also, assembleRelease do not produce any .asc file so maybe that line can be removed.

https://github.com/brosssh/revanced-manager/actions/runs/15465948686/job/43537932873

@brosssh brosssh requested a review from oSumAtrIX June 5, 2025 12:07
@brosssh brosssh added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jun 5, 2025
@brosssh brosssh linked an issue Jun 5, 2025 that may be closed by this pull request
4 tasks
@validcube validcube self-requested a review June 5, 2025 12:22
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞🏗️ Infra LGTM!


?(.asc) is not supported in GitHub actions (I think).

Correct, ?(.asc) is an extended glob, GitHub supports only standard posix flavoured glob

Also, assembleRelease do not produce any .asc file so maybe that line can be removed.

According to this task configuration

https://github.com/ReVanced/revanced-manager/blob/compose-dev/app/build.gradle.kts#L241

I believe on every assembleRelease it should generate .asc file.

@brosssh brosssh changed the title fix: Build request CI fix: CI flows Jun 6, 2025
@brosssh
Copy link
Member Author

brosssh commented Jun 6, 2025

I also commited the package-lock.json, which is needed for npm ci (in release workflow).

@brosssh brosssh marked this pull request as draft June 6, 2025 08:13
@brosssh
Copy link
Member Author

brosssh commented Jun 6, 2025

@brosssh brosssh requested a review from validcube June 6, 2025 08:41
@brosssh brosssh marked this pull request as ready for review June 6, 2025 08:41
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞🏗️ Infra LGTM!

@validcube validcube requested a review from Copilot June 6, 2025 12:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI flow issues by adjusting dependency names, improving the release workflow with GPG key import, and correcting artifact upload patterns.

  • Rename the semantic-release plugin dependency in package.json
  • Add GPG key import step and update APK subject path in release workflow
  • Split artifact upload paths in the PR build workflow to handle .apk and .asc files explicitly

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Update semantic-release plugin dependency name
.github/workflows/release.yml Add GPG import step; update APK subject-path
.github/workflows/build_pull_request.yml Expand artifact upload paths to .apk and .apk.asc
Comments suppressed due to low confidence (2)

package.json:4

  • Verify that the NPM package name is correct—if the plugin is scoped under @revanced, retaining the scoped name (@revanced/gradle-semantic-release-plugin) may be necessary to resolve it correctly.
"gradle-semantic-release-plugin": "^1.10.1",

.github/workflows/build_pull_request.yml:33

  • The .apk.asc artifact isn’t produced by assembleRelease, so this upload path will fail. Remove this line or set if-no-files-found: warn to avoid CI errors when the file is missing.
app/build/outputs/apk/release/revanced-manager*.apk.asc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: can not create artifact with compose-dev
3 participants