Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision of approximations #276

Closed
albertpod opened this issue Feb 22, 2023 · 2 comments
Closed

Revision of approximations #276

albertpod opened this issue Feb 22, 2023 · 2 comments
Assignees
@albertpod
Labels
enhancement New feature or request

Comments

@albertpod
Copy link
Member

The issue at hand pertains to the ReactiveMP.jl folder named approximations/, which is growing and being poorly maintained.
In essence, approximation methods should not be included in message-passing since they are semantically distinct entities.
The proposed solution is to enhance and relocate the approximation/ folder within ExpectationApproximations.jl
@albertpod albertpod self-assigned this Feb 22, 2023
@albertpod albertpod added the enhancement New feature or request label Feb 22, 2023
@bartvanerp
Copy link
Member

Is this a duplicate of #27?

@albertpod
Copy link
Member Author

Yes, I think also this one is linked #74

I will probably close this one for the sake of the previously opened issue #27.

@albertpod albertpod closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertpod albertpod

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertpod @bartvanerp