"Package did not load correctly" on direct loading some solutions/projects

[AHollowedHunter]

I'm having issues with the extension failing to load when launching certain Solutions/Projects directly from the .sln or .csproj files, but not all solutions exhibit this behaviour.

If I open VS directly and select a solution to open once VS is already running, I don't encounter this issue, so is a workaround for now.

• After further testing, I found that I need to wait for the extension to start and my 'Activity' in discord to show 'No active [solution/project]' before I open a problematic solution. If I open a solution quickly before the extension has had time to fully start, the same issue occurs again.

I cannot pinpoint for certain anything specific about the solutions to cause this issue, yesterday I had this problem on a bunch of different solutions and project, and I ended up reinstalling the extension after first clearing my config folder. After a fresh install of the extension, everything was working again on any solution. I updated my settings and continued working fine.

Upon launching a solution today, the same error occurs. Weirdly, other solutions that this issue would happen before I reinstalled won't cause this issue; hence I find it hard to pinpoint if there is something specific about any solutions to trigger this. But...

Windows targets - related or redhearing?

The solution I had the issue with today contains a WinUI 3 project, targetting net6.0-windows. I was looking through issues and in #39 saw they reinstalled the Windows SDK and the problem was gone. I found another solution I had on hand that this error occurs with, and it turns out that has a project targetting net7.0-windows; if someone wants to try and reproduce it was ValveResourceFormat, or possible try creating a new project that builds a Windows application. This might be coincidence though, as I was getting this error before with other project targets.

---

Windows 11 Pro, 22621.2428
Visual Studio 17.8.0 Preview 5, Community 2022
VisualStudioDiscordRPC 1.6.1

Error Extract:

  <entry>
    <record>385</record>
    <time>2023/10/28 12:11:24.200</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>Begin package load [VisualStudioDiscordRPCPackage]</description>
    <guid>{5CD3D640-3D33-45EA-8C5B-6DE981FF9900}</guid>
  </entry>
  <entry>
    <record>386</record>
    <time>2023/10/28 12:11:24.217</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>Begin package load [Microsoft.VisualStudio.Shell.Connected.ConnectedUser.ConnectedUserPackage]</description>
    <guid>{7F679D93-2EB6-47C9-85EB-F6AD16902662}</guid>
  </entry>
  <entry>
    <record>387</record>
    <time>2023/10/28 12:11:24.285</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>End package load [Microsoft.VisualStudio.Shell.Connected.ConnectedUser.ConnectedUserPackage]</description>
    <guid>{7F679D93-2EB6-47C9-85EB-F6AD16902662}</guid>
  </entry>
  <entry>
    <record>388</record>
    <time>2023/10/28 12:11:24.286</time>
    <type>Error</type>
    <source>VisualStudio</source>
    <description>SetSite failed for package [VisualStudioDiscordRPCPackage]Source: &apos;Microsoft.VisualStudio.Interop&apos; Description: Value does not fall within the expected range.&#x000D;&#x000A;System.ArgumentException: Value does not fall within the expected range.&#x000D;&#x000A;   at EnvDTE80.DTE2.get_ActiveDocument()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Variables.FileNameVariable..ctor(VsObserver vsObserver)&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Services.VariableService..ctor(VsObserver vsObserver)&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.RegisterServices()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.Init()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.VisualStudioDiscordRPCPackage.&lt;InitializeAsync&gt;d__2.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#x000D;&#x000A;   at Microsoft.VisualStudio.Shell.AsyncPackage.&lt;&gt;c__DisplayClass21_0.&lt;&lt;Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize&gt;b__1&gt;d.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.RethrowException(AggregateException e)&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.InternalGetResult(Boolean ignoreUIThreadCheck)</description>
    <guid>{5CD3D640-3D33-45EA-8C5B-6DE981FF9900}</guid>
    <hr>0x80070057 - E_INVALIDARG</hr>
    <errorinfo></errorinfo>
  </entry>
<!-- NO MORE ENTRIES AFTER THIS -->

[Reavert]

Hi.
I see a problem in your error log.
Something is wrong with the variable system that appeared in version 1.6.0.
The error occurred on the IDE side when the extension requested the currently active document.
But I can't figure out why it happened yet.
I'm trying to reproduce the bug now.

[AHollowedHunter]

aha. In which case I'll attach my current settings below:

{
  "RichPresenceEnabled": true,
  "Language": "English",
  "LargeIconPlug": "ExtensionIconPlug",
  "SmallIconPlug": "VisualStudioVersionIconPlug",
  "DetailsPlug": "SolutionNameTextPlug",
  "StatePlug": "ProjectNameTextPlug",
  "TimerPlug": "ApplicationScopeTimerPlug",
  "FirstButtonPlug": "GitRepositoryButtonPlug",
  "SecondButtonPlug": "NoneButtonPlug",
  "ApplicationID": "914622396630175855",
  "UpdateTimeout": 1000,
  "Version": "1.6.1",
  "UpdateNotifications": true,
  "TranslationsPath": "Translations/"
}

These were set via the extension settings menu after I reinstalled 1.6.1 yesterday

[Reavert]

Hm.. Everything is fine with the settings here.
Then one more question.
Have you created any of your own plugs through this menu?

[AHollowedHunter]

Not currently.

I did use one before reinstalling yesterday, but I had already reset my config to default before that. My current custom_plugs.json is an empty array: [], and settings as above

[Reavert]

Okay.
I just made a debugging build. I changed the interface through which the interaction takes place to an older one.
Can you please delete the current version of the extension and install this one?
VisualStudioDiscordRPC.Dev17.zip

[AHollowedHunter]

I removed the old version, cleared the old config folder, and installed the debug build.

I launched my solution directly and the error came up again. The extension has recreated the config folder in ~\AppData\Local\VisualStudioDiscordRPC, but the folder remains empty. I am unable to edit the settings as the same error popup occurs when attempting to open the extension settings.

  <entry>
    <record>2218</record>
    <time>2023/10/28 14:24:38.726</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>Begin package load [VisualStudioDiscordRPCPackage]</description>
    <guid>{5CD3D640-3D33-45EA-8C5B-6DE981FF9900}</guid>
  </entry>
  <entry>
    <record>2219</record>
    <time>2023/10/28 14:24:38.757</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>Begin package load [Microsoft.VisualStudio.Shell.Connected.ConnectedUser.ConnectedUserPackage]</description>
    <guid>{7F679D93-2EB6-47C9-85EB-F6AD16902662}</guid>
  </entry>
  <entry>
    <record>2220</record>
    <time>2023/10/28 14:24:38.848</time>
    <type>Information</type>
    <source>VisualStudio</source>
    <description>End package load [NuGetPackage]</description>
    <guid>{5FCC8577-4FEB-4D04-AD72-D6C629B083CC}</guid>
  </entry>
  <entry>
    <record>2221</record>
    <time>2023/10/28 14:24:38.848</time>
    <type>Error</type>
    <source>VisualStudio</source>
    <description>SetSite failed for package [VisualStudioDiscordRPCPackage]Source: &apos;VisualStudioDiscordRPC.Dev17&apos; Description: Object reference not set to an instance of an object.&#x000D;&#x000A;System.NullReferenceException: Object reference not set to an instance of an object.&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Services.SettingsService.MigrateFromLegacySettings()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Services.SettingsService..ctor()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.RegisterServices()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.Init()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.VisualStudioDiscordRPCPackage.&lt;InitializeAsync&gt;d__2.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#x000D;&#x000A;   at Microsoft.VisualStudio.Shell.AsyncPackage.&lt;&gt;c__DisplayClass21_0.&lt;&lt;Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize&gt;b__1&gt;d.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.RethrowException(AggregateException e)&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.InternalGetResult(Boolean ignoreUIThreadCheck)</description>
    <guid>{5CD3D640-3D33-45EA-8C5B-6DE981FF9900}</guid>
    <hr>0x80004003 - E_POINTER</hr>
    <errorinfo></errorinfo>
  </entry>

I attempted to open another solution which was working this morning, and it too gives the same error as above.

Finally I tried launching VS without any solution, and the extension errors out then too

[Reavert]

Oh. Sorry. This is another error. Try again with this one
VisualStudioDiscordRPC.Dev17.zip

[AHollowedHunter]

Okay, so I cleared the config and installed that newer one.

I directly launched my solution that was erroring. It loaded fine, and my discord activity updated.
I closed VS and re-opened the same solution, no error.
I closed VS and re-opened the ValveResourceFormat solution, the error occurs again.
I closed and tried my solution again, no error.
I tried other solutions too, none are erroring.

  <entry>
    <record>388</record>
    <time>2023/10/28 14:43:27.167</time>
    <type>Error</type>
    <source>VisualStudio</source>
    <description>SetSite failed for package [VisualStudioDiscordRPCPackage]Source: &apos;&apos; Description: The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))&#x000D;&#x000A;System.ArgumentException: The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))&#x000D;&#x000A;   at EnvDTE.DTE.get_ActiveDocument()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Variables.FileNameVariable..ctor(VsObserver vsObserver)&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.Services.VariableService..ctor(VsObserver vsObserver)&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.RegisterServices()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.PackageController.Init()&#x000D;&#x000A;   at VisualStudioDiscordRPC.Shared.VisualStudioDiscordRPCPackage.&lt;InitializeAsync&gt;d__2.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)&#x000D;&#x000A;   at Microsoft.VisualStudio.Shell.AsyncPackage.&lt;&gt;c__DisplayClass21_0.&lt;&lt;Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize&gt;b__1&gt;d.MoveNext()&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.RethrowException(AggregateException e)&#x000D;&#x000A;   at Microsoft.VisualStudio.Services.VsTask.InternalGetResult(Boolean ignoreUIThreadCheck)</description>
    <guid>{5CD3D640-3D33-45EA-8C5B-6DE981FF9900}</guid>
    <hr>0x80070057 - E_INVALIDARG</hr>
    <errorinfo></errorinfo>
  </entry>

I will restart and try again

[AHollowedHunter]

Same situation after restart, only VRF solution will cause the error. All my own solutuions work fine.

I will update my settings and try a few more times

[Reavert]

I will try to clone and run the same solution.

[AHollowedHunter]

I tried changing my settings one-by-one, nothing changed for anything. Still only VRF was causing issues.

I tried another test, I deleted my .vs folder from that solutions root, and upon launch nothing errored, and the extension correctly updated my discord activity!

I checked for a fluke, I deleted the new folder, restored the old: Error. I delete it again, loaded it and no error with a clean .vs folder.

[Reavert]

Hm... It's confusing. I can't even guess why this happened and how it affects the extension.

[Reavert]

For me, the project started correctly and without any errors and correctly displayed activity in Discord

[AHollowedHunter]

For me, the project started correctly and without any errors and correctly displayed activity in Discord

That seems to match what happened for me when I cleared the .vs folder, effectively a fresh clone at that point.

There's a load of binary files in .vs, and I've had weirdness before where the solution is to nuke it. I tried a grep within the affected .vs folder for 'discord' or partial extension guid but nothing coming up.

[Reavert]

Maybe the project got damaged somehow when you were working in it. It affected .vs folder. Then, because of this corruption, the extension could not get the active document or something else.
It's hard to tell when an error occurs on the IDE side. I can't even look inside that method to debug.