tests, net, service-mesh: Drop usage of 'running_vm'

[EdDev]

What this PR does / why we need it:

running_vm is performing multiple checks to assure correct VM start. However, these checks are not required for the network tests.

For the network tests, a successful VM start is one that:

• Reaches ready status (i.e. a VMI in running phase).
• Reaches AgentConnected condition status (i.e. cloud-init stage succeeded based on the Fedora image setup).

This is an optimization to reduce observed flakiness on VM startup and simplify the overall maintenance (e.g. the use of a common helper that covers many aspects of a VM startup cycle forces all its users to the same logic, even though that logic is not of interest).

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Updated VM startup procedure in test fixtures to use explicit start and agent connection steps.

[coderabbitai]

Walkthrough

The import and usage of the running_vm utility function were removed from a network service mesh test configuration file. Instead, explicit calls to start the VM and wait for the agent connection are now used in relevant test fixtures. No other logic or control flow was altered.

Changes

File(s)	Change Summary
tests/network/service_mesh/conftest.py	Removed import of running_vm and replaced its usage with explicit vm.start(wait=True) and vm.wait_for_agent_connected() calls in two fixtures.

Possibly related issues

• tests, net, host-network: Drop usage of 'running_vm' - 1091 #1092: This PR removes usage of running_vm, directly aligning with the issue's objective to drop usage of that helper.

Possibly related PRs

• tests, net, network-policy: Drop usage of 'running_vm' #840: Removes running_vm usage in test fixtures, replacing it with explicit VM start and agent wait calls.
• tests, net, jumbo frame: Drop usage of 'running_vm' #826: Removes running_vm import and usage in network test fixtures, replacing with explicit VM start and wait methods.
• tests, net, upgrade: Drop usage of 'running_vm' #848: Removes running_vm and replaces it with explicit VM start and agent connection calls in test fixtures.

Suggested labels

verified, size/XS, can-be-merged, branch-main, tox:verify-tc-requirement-polarion:passed, lgtm-yossisegev, tox:verify-bugs-are-open:passed, sig-network, approved-EdDev

Suggested reviewers

• dshchedr
• dbasunag
• sbahar619
• Anatw
• vsibirsk
• yossisegev

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2adeba3 and ee6622d.

📒 Files selected for processing (1)

• tests/network/service_mesh/conftest.py (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/network/service_mesh/conftest.py (1)

utilities/virt.py (2)

• vm_console_run_commands (1316-1349)
• wait_for_console (1479-1481)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: can-be-merged
• GitHub Check: build-container
• GitHub Check: tox

🔇 Additional comments (3)

tests/network/service_mesh/conftest.py (3)

39-39: LGTM! Import cleanup aligns with PR objectives.

The removal of running_vm from the import statement is correct and consistent with the goal of dropping its usage in network tests.

---

238-239: LGTM! Simplified VM startup approach for network tests.

The replacement of running_vm() with explicit vm.start(wait=True) and vm.wait_for_agent_connected() calls successfully implements the PR objective. This approach:

1. Ensures the VM reaches running state (vm.start(wait=True))
2. Waits for cloud-init completion (vm.wait_for_agent_connected())

This targeted approach reduces complexity while maintaining the necessary checks for network testing scenarios.

---

258-259: LGTM! Consistent implementation across fixtures.

The same simplified VM startup approach is correctly applied to the second fixture, maintaining consistency with the first fixture and the overall PR objective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-virtualization-qe-bot-2]

Report bugs in Issues

The following are automatically added:

• Add reviewers from OWNER file (in the root of the repository) under reviewers section.
• Set PR size label.
• New issue is created for the PR. (Closed when PR is merged/closed)
• Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

• To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
• To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
  • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
  • Cherry-pick will be started when PR is merged
• To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • You can add extra args to the Podman build command
    • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
• To add a label by comment use /<label name>, to remove, use /<label name> cancel
• To assign reviewers based on OWNERS file use /assign-reviewers
• To check if PR can be merged use /check-can-merge
• to assign reviewer to PR use /assign-reviewer @<reviewer>

PR will be approved when the following conditions are met:

• /approve from one of the approvers.
• Minimum number of required /lgtm (2) is met.

Approvers and Reviewers

• Approvers:

  • EdDev

• Reviewers:

  • Anatw
  • EdDev
  • sbahar619
  • yossisegev

Supported /retest check runs

• /retest tox: Retest tox
• /retest build-container: Retest build-container
• /retest all: Retest all

Supported labels

• hold
• verified
• wip
• lgtm
• approve

[yossisegev]

/build-and-push-container

[openshift-virtualization-qe-bot-2]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-1093 published

[rnetser]

/approve
/lgtm