Do not break serializers for tipologia_notizia utility (#306)

* Do not break serializers if there is not tipologia_notizia taxonomy utility.

* convert getUtility in queryUtility

* [mauro] logica booleana su condizione apertura_bando

* changelog

* fix changelog

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Mauro Amico <[email protected]>

Author: 3 people

CHANGES.rst

@@ -4,8 +4,10 @@ Changelog
 6.3.8 (unreleased)
 ------------------
 
-- Nothing changed yet.
-
+- Do not break serializers if there is not tipologia_notizia taxonomy utility.
+  [cekk]
+- Fix operator order in condition in summary for apertura_bando
+  [mamico]
 
 6.3.7 (2025-04-28)
 ------------------
@@ -38,7 +40,6 @@ Changelog
   Add "Dichiarazioni di insussistenza e incompatibilità" to Persona
   [lucabel]
 
-
 6.3.4 (2025-03-07)
 ------------------
 

src/design/plone/contenttypes/patches/baseserializer.py

@@ -21,7 +21,7 @@
 from plone.restapi.serializer.dxcontent import SerializeToJson
 from Products.CMFCore.utils import getToolByName
 from zope.component import getMultiAdapter
-from zope.component import getUtility
+from zope.component import queryUtility
 from zope.i18n import translate
 
 
@@ -37,16 +37,21 @@ def design_italia_serialize_to_json_call(self, version=None, include_items=True)
         ttool[self.context.portal_type].Title(), context=self.request
     )
     if self.context.portal_type == "News Item":
-        if getattr(self.context, "tipologia_notizia", ""):
-            taxonomy = getUtility(
+        tipologia_notizia = getattr(self.context, "tipologia_notizia", "")
+        if tipologia_notizia:
+            taxonomy = queryUtility(
                 ITaxonomy, name="collective.taxonomy.tipologia_notizia"
             )
-            taxonomy_voc = taxonomy.makeVocabulary(self.request.get("LANGUAGE"))
-
-            title = taxonomy_voc.inv_data.get(self.context.tipologia_notizia, None)
-
-            if title and title.startswith(PATH_SEPARATOR):
-                result["design_italia_meta_type"] = title.replace(PATH_SEPARATOR, "", 1)
+            if taxonomy:
+                taxonomy_voc = taxonomy.makeVocabulary(self.request.get("LANGUAGE"))
+
+                title = taxonomy_voc.inv_data.get(self.context.tipologia_notizia, None)
+                if title and title.startswith(PATH_SEPARATOR):
+                    result["design_italia_meta_type"] = title.replace(
+                        PATH_SEPARATOR, "", 1
+                    )
+            else:
+                result["design_italia_meta_type"] = tipologia_notizia
     return result
 
 

src/design/plone/contenttypes/restapi/serializers/dxcontent.py

@@ -11,7 +11,7 @@
 )
 from plone.restapi.serializer.dxcontent import SerializeToJson as BaseSerializer
 from zope.component import adapter
-from zope.component import getUtility
+from zope.component import queryUtility
 from zope.i18n import translate
 from zope.interface import implementer
 
@@ -21,9 +21,11 @@ def get_design_meta_type(self):
         ttool = api.portal.get_tool("portal_types")
         tipologia_notizia = getattr(self.context, "tipologia_notizia", "")
         if self.context.portal_type == "News Item" and tipologia_notizia:
-            taxonomy = getUtility(
+            taxonomy = queryUtility(
                 ITaxonomy, name="collective.taxonomy.tipologia_notizia"
             )
+            if not taxonomy:
+                return tipologia_notizia
             taxonomy_voc = taxonomy.makeVocabulary(self.request.get("LANGUAGE"))
             if isinstance(tipologia_notizia, list):
                 token = tipologia_notizia[0]

src/design/plone/contenttypes/restapi/serializers/summary.py

@@ -22,7 +22,7 @@
 )
 from zope.component import adapter
 from zope.component import getMultiAdapter
-from zope.component import getUtility
+from zope.component import queryUtility
 from zope.component import queryMultiAdapter
 from zope.globalrequest import getRequest
 from zope.i18n import translate
@@ -42,10 +42,22 @@ def get_taxonomy_information(field_name, context, res):
     """
     Get the proper values for taxonomy fields
     """
+    value = getattr(context, field_name, None)
+    if not value:
+        return res
+
     request = getRequest()
-    taxonomy = getUtility(ITaxonomy, name=f"collective.taxonomy.{field_name}")
-    taxonomy_voc = taxonomy.makeVocabulary(request.get("LANGUAGE"))
 
+    taxonomy = queryUtility(ITaxonomy, name=f"collective.taxonomy.{field_name}")
+    if not taxonomy:
+        # utility not found, return default
+        if isinstance(value, list):
+            res[field_name] = [{"token": token, "title": token} for token in value]
+        else:
+            res[field_name] = {"token": value, "title": value}
+        return res
+
+    taxonomy_voc = taxonomy.makeVocabulary(request.get("LANGUAGE"))
     # il summary di un fullobject torna un value
     # il summary di un brain torna una lista (collective.taxonomy ha motivi per
     # fare così).
@@ -238,9 +250,12 @@ def get_design_meta_type(self):
         if self.context.portal_type == "News Item":
             tipologia_notizia = getattr(self.context, "tipologia_notizia", "")
             if tipologia_notizia:
-                taxonomy = getUtility(
+                taxonomy = queryUtility(
                     ITaxonomy, name="collective.taxonomy.tipologia_notizia"
                 )
+                if not taxonomy:
+                    # utility not found, return default
+                    return tipologia_notizia
                 taxonomy_voc = taxonomy.makeVocabulary(self.request.get("LANGUAGE"))
                 if isinstance(tipologia_notizia, list):
                     token = tipologia_notizia[0]