Merge pull request #1207 from grilledham/start_game

Start game

Author: grilledham

control.lua

@@ -4,12 +4,13 @@
 require 'resources.data_stages'
 _LIFECYCLE = _STAGE.control -- Control stage
 
+-- Util libraries, omitting is a very bad idea
+require 'utils.math'
+require 'utils.string'
+
 -- Overrides the _G.print function
 require 'utils.print_override'
 
--- Omitting the math library is a very bad idea
-require 'utils.math'
-
 -- Global Debug and make sure our version file is registered
 Debug = require 'utils.debug'
 require 'resources.version'

features/gui/camera.lua

@@ -39,7 +39,7 @@ local function create_camera(args, player)
     local mainframeid = 'mainframe_' .. player_index
     local mainframe = mainframeflow[mainframeid]
 
-    local target = game.players[args.target]
+    local target = game.get_player(args.target)
     if not target then
         player.print('Not a valid target')
         return

features/gui/poll.lua

@@ -132,7 +132,7 @@ local function send_poll_result_to_discord(poll)
     if next(edited_by_players) then
         insert(result, ' Edited by ')
         for pi, _ in pairs(edited_by_players) do
-            local p = game.players[pi]
+            local p = game.get_player(pi)
             if p and p.valid then
                 insert(result, p.name)
                 insert(result, ', ')

features/gui/popup.lua

@@ -130,7 +130,7 @@ end
 -- Creates a popup dialog for the specifically targetted player
 local function popup_player(args)
     local target_name = args.player
-    local target = game.players[target_name]
+    local target = game.get_player(target_name)
     if not target then
         Game.player_print('Player ' .. target_name .. ' not found.')
         return

features/gui/tag_group.lua

@@ -785,7 +785,7 @@ Event.add(
 Event.add(defines.events.on_player_created, player_created)
 
 local function tag_command(args)
-    local target_player = game.players[args.player]
+    local target_player = game.get_player(args.player)
 
     if not target_player then
         Game.player_print({'common.fail_no_target', target_player})

features/gui/toast.lua

@@ -277,7 +277,7 @@ Command.add(
     },
     function(args)
         local target_name = args.player
-        local target = game.players[target_name]
+        local target = game.get_player(target_name)
         if target then
             Public.toast_player(target, 15, args.msg)
             Utils.print_admins({'command_description.sent_player_toast', Utils.get_actor(), target_name})

features/player_colors.lua

@@ -20,7 +20,7 @@ local color_callback = Token.register(function(data)
         return
     end
 
-    local player = game.players[key]
+    local player = game.get_player(key)
     if not player then
         return
     end

features/rank_system.lua

@@ -149,7 +149,7 @@ end
 -- purposes of sorting.
 -- Is the only place player.admin should be checked.
 function Public.get_player_rank(player_name)
-    local player = game.players[player_name]
+    local player = game.get_player(player_name)
     if player and player.valid and player.admin then
         return Ranks.admin
     elseif everyone_is_regular then
@@ -319,7 +319,7 @@ function Public.set_player_rank(player_name, rank)
         player_ranks[player_name] = nil
         Server.set_data(ranking_data_set, player_name, nil)
         -- If we're dropping someone back down the guest, put them on the guests list
-        local player = game.players[player_name]
+        local player = game.get_player(player_name)
         if player and player.valid then
             guests[player.index] = player
         end
@@ -343,7 +343,7 @@ function Public.reset_player_rank(player_name)
     if Public.equal(player_name, guest_rank) then
         return false, get_rank_name(guest_rank)
     else
-        local player = game.players[player_name]
+        local player = game.get_player(player_name)
         local rank
         if player and player.valid and (player.online_time > trust_time) then
             rank = auto_trusted

features/redmew_qol.lua

@@ -49,7 +49,7 @@ end)
 --- Selects a name from the entity backer name, game.players, and regulars
 local function pick_name()
     -- Create a weight table comprised of the backer name, a player's name, and a regular's name
-    local random_player = game.players[random(#game.players)]
+    local random_player = game.get_player(random(#game.players))
     if not random_player then
         return
     end

features/report.lua

@@ -44,7 +44,7 @@ end)
 
 local function report_command(args, player)
     local reported_player_name = args.player
-    local reported_player = game.players[reported_player_name]
+    local reported_player = game.get_player(reported_player_name)
 
     if not reported_player then
         Game.player_print(reported_player_name .. ' does not exist.')
@@ -482,12 +482,12 @@ end)
 
 Gui.on_click(jail_offender_button_name, function(event)
     local target_name = string.sub(event.element.caption, 6)
-    local target = game.players[target_name]
+    local target = game.get_player(target_name)
     if target then
         Module.jail(target, event.player)
     else
         target_name = string.sub(event.element.caption, 8)
-        target = game.players[target_name]
+        target = game.get_player(target_name)
         if target then
             Module.unjail(target, event.player)
         end