perf: avoid primitive boxing in gcFreeChunkSerializer

Author: MCRcortex

c2me-rewrites-chunk-serializer/src/main/java/com/ishland/c2me/rewrites/chunk_serializer/common/ChunkDataSerializer.java

@@ -248,8 +248,9 @@ private static void putShortListArray(ShortList[] data, NbtWriter writer, byte[]
         for (ShortList shortList : data) {
             if (shortList != null) {
                 writer.startFixedListEntry(shortList.size(), NbtElement.SHORT_TYPE);
-                for (Short short_ : shortList) {
-                    writer.putShortEntry(short_);
+                var iter = shortList.iterator();
+                while (iter.hasNext()) {
+                    writer.putShortEntry(iter.nextShort());
                 }
             } else {
                 writer.startFixedListEntry(0, NbtElement.SHORT_TYPE);
@@ -381,7 +382,7 @@ private static void writeBiomes(NbtWriter writer, ReadableContainer<RegistryEntr
         Optional<LongStream> storage = data.storage();
         //noinspection OptionalIsPresent
         if (storage.isPresent()) {
-            writer.putLongArray(STRING_DATA, storage.get().toArray());
+            writer.putLongArray(STRING_DATA, storage.get());
         }
         writer.finishCompound();
     }
@@ -450,8 +451,9 @@ public static NbtList toNbt(ShortList[] lists) {
         for (ShortList shortList : lists) {
             NbtList nbtList2 = new NbtList();
             if (shortList != null) {
-                for (Short short_ : shortList) {
-                    nbtList2.add(NbtShort.of(short_));
+                var iter = shortList.iterator();
+                while (iter.hasNext()) {
+                    nbtList2.add(NbtShort.of((iter.nextShort())));
                 }
             }
 

c2me-rewrites-chunk-serializer/src/main/java/com/ishland/c2me/rewrites/chunk_serializer/common/NbtWriter.java

@@ -15,6 +15,7 @@
 import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.List;
+import java.util.stream.LongStream;
 
 @SuppressWarnings("WeakerAccess")
 public class NbtWriter {
@@ -106,10 +107,11 @@ private void insertLongArray(long[] value) {
     }
 
     private void insertLongArray(LongIterable value) {
-        value.forEach(i -> {
-            UNSAFE.putLong(this.pointer, Long.reverseBytes(i));
+        var iter = value.longIterator();
+        while (iter.hasNext()) {
+            UNSAFE.putLong(this.pointer, Long.reverseBytes(iter.nextLong()));
             this.pointer += 8;
-        });
+        }
     }
 
     //region list entries
@@ -397,6 +399,23 @@ public void putLongArray(byte[] name, LongCollection value) {
         this.insertLongArray(value);
     }
 
+    public void putLongArray(byte[] name, LongStream value) {
+        this.claimCapacity(1L + name.length + 4);
+        this.insertByte(NbtElement.LONG_ARRAY_TYPE);
+        this.insertByteArray(name);
+        long offset = this.getOffset();
+        this.insertInt(-1); //Holder
+        int count = 0;
+        var iter = value.iterator();
+        while (iter.hasNext()) {
+            this.claimCapacity(8);
+            UNSAFE.putLong(this.pointer, Long.reverseBytes(iter.nextLong()));
+            this.pointer += 8;
+            count++;
+        }
+        UNSAFE.putInt(this.buffer + offset, Integer.reverseBytes(count));
+    }
+
 
     @Deprecated
     public void putElement(String name, NbtElement data) {