claude driven dark mode #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachBeta
commented
Oct 1, 2025
src/app/layout.tsx
Outdated
| })(); | ||
| `, | ||
| }} | ||
| /> |
Author
There was a problem hiding this comment.
there is probably a better way to handle this but this avoids a flashbang on load so that it doesn't start light and quickly flip to dark
Member
There was a problem hiding this comment.
we should rely on the css value, rather than relying on javascript
switz
reviewed
Oct 1, 2025
src/components/ThemeToggle.tsx
Outdated
|
|
||
| // Update cookie and refresh server-side data | ||
| await setThemeCookie(newTheme); | ||
| router.refresh(); |
Member
There was a problem hiding this comment.
shouldnt be necessary (will cause some issues too) since you already are manually updating className
switz
reviewed
Oct 1, 2025
|
|
||
| export type Theme = 'light' | 'dark'; | ||
|
|
||
| export async function getTheme(): Promise<Theme | null> { |
Member
There was a problem hiding this comment.
this will create a server action (since use server) which isn't necessary since its only called from the server.
setTheme can be a server action, but it should include validation (theme can only be light|dark)
Author
|
will revisit again, ideally later today time permitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first draft of dark mode for #91