Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options not required by having parameterless ctor new up the options itself. #3

Closed
wants to merge 1 commit into from

Conversation

AraHaan
Copy link
Contributor

@AraHaan AraHaan commented Jul 8, 2022

Fixes #2.

@Nihlus
Copy link
Member

Nihlus commented Jul 8, 2022

This goes against DI design in general; closing.

@Nihlus Nihlus closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make options not required for when following the readme.
2 participants