-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor APCDataSubstrate and APCUser to make them modular #43
Comments
APCDataSubstrateIt seems it would make sense to create two protocols for the data substrate:
APCUserThe user's interface could be converted into a protocol as-is. The current implementation could then be put into an actual class, maybe @jwe-apple As per your comment on #41, as a first step I'd leave the current APCUser implementation as-is to get this going. Then we can see if we want your object composition idea reflected in the protocol or just have the APC implementation follow that pattern. Hope this is okay. I will start with this on a branch because I need it as protocols for our app. |
Makes sense to me. |
Internationalization
As mentioned in #41, the data substrate and especially APCUser are tightly coupled to various parts of AppCore and the Bridge SDK. It would be nice to have these as protocols but keep the existing code as implementations of those protocols. Additionally, APCDataSubstrate (as-is) should take care of the stack initialization, not the app delegate.
The text was updated successfully, but these errors were encountered: