Refactor AutoRoute according to new implementatiaon #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NestorBurma1
commented
Sep 5, 2021
NestorBurma1
commented
- Replace builder ExtendedNavigator with AutoRouterDelegate and routeInformationParser in app_widget.dart.
- Deleted generateNavigationHelperExtension in router.dart.
- Replaced MaterialRoute with AutoRoute in router.dart.
- Replaced ExtendedNavigator.of(context).replace with context.router.replace in splash_page.dart.
- Update auto_route version in pubspec.yaml.
1. Deleted line generateNavigationHelperExtension: true. 2. Renamed MaterialRoute to AutoRoute.
ExtendedNavigator replaced with AutoRouterDelegate.
Replaced ExtendedNavigator.of(context).replace(Routes.notesOverviewPage), with context.router.replace(NotesOverviewPage(),), and ExtendedNavigator.of(context).replace(Routes.signInPage), with context.router.replace(SignInPageRoute(),),
New version 2.3.0
| @@ -10,17 +10,19 @@ import 'package:notes_firebase_ddd_course/presentation/sign_in/sign_in_page.dart | |||
| class AppWidget extends StatelessWidget { | |||
| @override | |||
| Widget build(BuildContext context) { | |||
| final _appRouter = app_router.Router(); | |||
There was a problem hiding this comment.
The router should be initialized outside the build(), otherwise, on hot restart it's gonna return an empty screen
There was a problem hiding this comment.
Yes definitely! Thanks for pointing that out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.