Skip to content

Create a melodic-devel branch and pull from my fork #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DasRoteSkelett opened this issue Mar 24, 2022 · 6 comments
Closed

Create a melodic-devel branch and pull from my fork #186

DasRoteSkelett opened this issue Mar 24, 2022 · 6 comments

Comments

@DasRoteSkelett
Copy link
Contributor

I added a melodic-devel branch here and changed .travis.yml accordingly. Please consider opening a melodic-devel branch and pull from my repo.

@chris-smith
Copy link
Collaborator

I've preferred to keep everything in one branch since there I don't think there are any differences between kinetic/melodic/etc that would actually impact rosnodejs but kinetic and xenial are also EOL... so I think the main question would be if we want to keep testing that distro and supporting people on it beyond osrf. Seems like it would be ok to me.

Any thoughts @chfritz ?

@chris-smith
Copy link
Collaborator

We should definitely update the node versions we test too

@chfritz
Copy link
Contributor

chfritz commented Mar 30, 2022

I don't think it's critical to test against kinetic, but one thing I'll say for sure: the fact that the main branch is called kinetic-devel has turned people off in the past, telling me that rosnodejs only exists/works for kinetic, which of course isn't true. And I agree with your assessment that there are no real difference between those versions that impact rosnodejs. So perhaps just rename the main branch to devel? Testing against multiple versions should be possible without having separate branches.

@chris-smith
Copy link
Collaborator

Sounds good to me. I'll rename to devel and we can update our testing accordingly.

@DasRoteSkelett
Copy link
Contributor Author

DasRoteSkelett commented Mar 31, 2022

i will pull request then, if you like. Maybe waiting on #185 to be merged

@DasRoteSkelett
Copy link
Contributor Author

nvm, i see #189 already does the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants