Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MagicString.indent is slow #94

Open
Victorystick opened this issue Jul 29, 2016 · 1 comment
Open

MagicString.indent is slow #94

Victorystick opened this issue Jul 29, 2016 · 1 comment

Comments

@Victorystick
Copy link

According to rollup/rollup#723 (comment), MagicString.indent can take up quite a bit of Rollup's bundle time. It may be worthwhile to try to optimize it.

@Rich-Harris
Copy link
Owner

Yeah. It's not any slower than any other operation, it's just that it needs to do a lot more of it (Rollup only needs to make small edits here and there until indent(), at which point every line is affected) – would definitely be good to make it faster, but it may be the case that we're better off just disabling indentation by default. Won't be able to take a look any time soon (am on a harsh deadline hence my recent radio silence!) but keen to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants