Skip to content

Commit ea7f300

Browse files
saubykShahanaFarooqui
authored andcommitted
Nodejs update for CI & Docker and updated documentation
1 parent 43a46b6 commit ea7f300

File tree

8 files changed

+34
-34
lines changed

8 files changed

+34
-34
lines changed

.DS_Store

0 Bytes
Binary file not shown.

.github/docs/Core_lightning_setup.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
![](../screenshots/RTL-CLN-Dashboard.png)
1+
![](../screenshots/RTL-CLN-Arch-3.png)
22

33
## RTL Core lightning setup
44

@@ -10,16 +10,16 @@
1010
* [Start the server and access the app](#start)
1111

1212
### <a name="intro"></a>Introduction
13-
RTL is now enabled to manage lightning nodes running Core Lightning.
13+
RTL is now enabled to manage lightning nodes running Core Lightning
1414

15-
Follow the below steps to install and setup RTL to run on Core Lightning.
15+
Follow the below steps to install and setup RTL to run on Core Lightning
1616

1717
### <a name="prereq"></a>Pre-requisites:
1818
1. Functioning Core Lightning node. Follow install instructions on their [github](https://github.com/ElementsProject/lightning)
1919
2. NodeJS - Can be downloaded [here](https://nodejs.org/en/download)
20-
3. clnrest - Ensure that core lightning's `clnrest` API server is configured. Configuration instructions [here](https://docs.corelightning.org/docs/rest#configuration)
21-
4. Create/reuse a rune created by core-lightning. Check [`createrune`](https://docs.corelightning.org/reference/lightning-createrune) and [`showrunes`](https://docs.corelightning.org/reference/lightning-showrunes) commands documentation for more details.
22-
4. Copy the `rune` and save it in a file named `.commando`, on which RTL will be installed.
20+
3. CLNRest - Ensure that core lightning's `CLNRest` API server is configured. Configuration instructions [here](https://docs.corelightning.org/docs/rest#configuration)
21+
4. Create/reuse core-lightning's rune. Check [`createrune`](https://docs.corelightning.org/reference/lightning-createrune) and [`showrunes`](https://docs.corelightning.org/reference/lightning-showrunes) documentation for more details on how to create runes
22+
4. Copy the `rune` and save it in a file which must be accessible to RTL. The content of the file must be `LIGHTNING_RUNE="<your-rune>"`
2323

2424
### <a name="arch"></a>Architecture
2525
![](../screenshots/RTL-CLN-Arch-2.png)
@@ -49,17 +49,17 @@ $ npm install --omit=dev
4949
If there is an error with `upstream dependency conflict` message then replace `npm install --omit=dev` with `npm install --omit=dev --legacy-peer-deps`.
5050

5151
### <a name="prep"></a>Prep for Execution
52-
RTL requires its own config file `RTL-Config.json`, to start the server and provide user authentication on the app.
53-
* Rename the file `Sample-RTL-Config.json` to `RTL-Config.json` located at`./RTL`..
54-
* Locate the complete path of the readable `.commando` file on your node.
52+
RTL requires its own config file `RTL-Config.json`, to start the server and provide user authentication on the app
53+
* Rename the file `Sample-RTL-Config.json` to `RTL-Config.json` located at`./RTL`
54+
* Locate the complete path of the readable `.commando` file on your node
5555
* Modify the RTL conf file per the example file below
5656

5757
Ensure that the follow values are correct per your config:
58-
* `lnImplementation` - This should be `CLN`, indicating that RTL is connecting to a core lightning node.
59-
* `runePath` - Path of the folder including filename which contains `rune` for the node. This rune in the file should be saved in `LIGHTNING_RUNE="your-rune"` format.
60-
* `lnServerUrl` - complete url with ip address and port of the cl-rest server.
61-
* `multiPass` - Specify the password (in plain text) to access RTL. This password will be hashed and not stored as plain text.
62-
* `configPath` (optional) - File path of the core lightning config file, if RTL server is local to the core lightning server.
58+
* `lnImplementation` - This should be `CLN`, indicating that RTL is connecting to a core lightning node
59+
* `runePath` - Path of the folder including **filename** which contains the `rune` for the node. The content of the file must be `LIGHTNING_RUNE="<your-rune>"`
60+
* `lnServerUrl` - complete url with ip address and port of the CLNRest server
61+
* `multiPass` - Specify the password (in plain text) to access RTL. This password will be hashed and not stored as plain text
62+
* `configPath` (optional) - File path of the core lightning config file, if RTL server is local to the core lightning server
6363

6464
```
6565
{
@@ -89,7 +89,7 @@ Ensure that the follow values are correct per your config:
8989
"logLevel": "INFO",
9090
"fiatConversion": false,
9191
"unannouncedChannels": false,
92-
"lnServerUrl": "https://<cl-rest api server ip address>:3001"
92+
"lnServerUrl": "https://<CLNRest api server ip address>:3001"
9393
}
9494
}
9595
]
@@ -102,9 +102,9 @@ Run the following command:
102102

103103
If the server started successfully, you should get the below output on the console:
104104

105-
`$ Server is up and running, please open the UI at http://localhost:3000 or your proxy configured url.`
105+
`$ Server is up and running, please open the UI at http://localhost:3000 or your proxy configured url`
106106

107-
Open your browser at the following address: http://localhost:3000 to access the RTL app.
107+
Open your browser at the following address: http://localhost:3000 to access the RTL app
108108

109109
### Detailed config and instructions
110-
For detailed config and access options and other information, view the main readme page.
110+
For detailed config and access options and other information, view the main readme page
139 KB
Loading

.github/workflows/checks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333

3434
- name: Install NPM dependencies
3535
if: steps.cache-npm-packages.outputs.cache-hit != 'true'
36-
run: npm ci --legacy-peer-deps
36+
run: npm ci
3737

3838
lint:
3939
name: Lint
@@ -57,7 +57,7 @@ jobs:
5757

5858
- name: Install NPM dependencies
5959
if: steps.cache-npm-packages.outputs.cache-hit != 'true'
60-
run: npm ci --legacy-peer-deps
60+
run: npm ci
6161

6262
- name: Lint Scripts
6363
run: npm run lint
@@ -89,7 +89,7 @@ jobs:
8989

9090
- name: Install NPM dependencies
9191
if: steps.cache-npm-packages.outputs.cache-hit != 'true'
92-
run: npm ci --legacy-peer-deps
92+
run: npm ci
9393

9494
- name: Run tests
9595
run: npm run test

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434

3535
- name: Install NPM dependencies
3636
if: steps.cache-npm-packages.outputs.cache-hit != 'true'
37-
run: npm ci --legacy-peer-deps
37+
run: npm ci
3838

3939
- name: Cache build frontend
4040
uses: actions/cache@v2

dockerfiles/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# ---------------
22
# Install Dependencies
33
# ---------------
4-
FROM node:16-alpine as builder
4+
FROM node:18-alpine as builder
55

66
WORKDIR /RTL
77

88
COPY package.json /RTL/package.json
99
COPY package-lock.json /RTL/package-lock.json
1010

11-
RUN npm install --legacy-peer-deps
11+
RUN npm install
1212

1313
# ---------------
1414
# Build App
@@ -22,12 +22,12 @@ RUN npm run buildfrontend
2222
RUN npm run buildbackend
2323

2424
# Remove non production necessary modules
25-
RUN npm prune --production --legacy-peer-deps
25+
RUN npm prune --production
2626

2727
# ---------------
2828
# Release App
2929
# ---------------
30-
FROM node:16-alpine as runner
30+
FROM node:18-alpine as runner
3131

3232
WORKDIR /RTL
3333

dockerfiles/Dockerfile.arm32v7

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ---------------
22
# Install Dependencies
33
# ---------------
4-
FROM node:16-stretch-slim as builder
4+
FROM node:18-alpine as builder
55

66
ADD https://github.com/krallin/tini/releases/download/v0.19.0/tini-static-armel /tini
77
ADD https://github.com/krallin/tini/releases/download/v0.19.0/tini-static-armel.asc /tini.asc
@@ -12,7 +12,7 @@ WORKDIR /RTL
1212
COPY package.json /RTL/package.json
1313
COPY package-lock.json /RTL/package-lock.json
1414

15-
RUN npm install --legacy-peer-deps
15+
RUN npm install
1616

1717
# ---------------
1818
# Build App
@@ -26,12 +26,12 @@ RUN npm run buildfrontend
2626
RUN npm run buildbackend
2727

2828
# Remove non production necessary modules
29-
RUN npm prune --production --legacy-peer-deps
29+
RUN npm prune --production
3030

3131
# ---------------
3232
# Release App
3333
# ---------------
34-
FROM arm32v7/node:16-stretch-slim as runner
34+
FROM arm32v7/node:18-alpine as runner
3535

3636
WORKDIR /RTL
3737

dockerfiles/Dockerfile.arm64v8

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ---------------
22
# Install Dependencies
33
# ---------------
4-
FROM node:16-stretch-slim as builder
4+
FROM node:18-alpine as builder
55

66
ADD https://github.com/krallin/tini/releases/download/v0.19.0/tini-static-arm64 /tini
77
RUN chmod +x /tini
@@ -11,7 +11,7 @@ WORKDIR /RTL
1111
COPY package.json /RTL/package.json
1212
COPY package-lock.json /RTL/package-lock.json
1313

14-
RUN npm install --legacy-peer-deps
14+
RUN npm install
1515

1616
# ---------------
1717
# Build App
@@ -25,12 +25,12 @@ RUN npm run buildfrontend
2525
RUN npm run buildbackend
2626

2727
# Remove non production necessary modules
28-
RUN npm prune --production --legacy-peer-deps
28+
RUN npm prune --production
2929

3030
# ---------------
3131
# Release App
3232
# ---------------
33-
FROM arm64v8/node:16-stretch-slim as runner
33+
FROM arm64v8/node:18-alpine as runner
3434

3535
WORKDIR /RTL
3636

0 commit comments

Comments
 (0)